refactor: remove unnecessary declaration in nameserver/name_server_impl.h #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
dl239
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2037 +/- ##
=============================================
+ Coverage 34.86% 75.58% +40.71%
Complexity 347 347
=============================================
Files 133 609 +476
Lines 8125 116463 +108338
Branches 1015 1015
=============================================
+ Hits 2833 88029 +85196
- Misses 5083 28225 +23142
Partials 209 209
Continue to review full report at Codecov.
|
dl239
approved these changes
Jun 27, 2022
aceforeverd
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fixed: Remove unnecessary declaration in nameserver/name_server_impl.h #1985
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?