Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send snapshot for disk table #2036

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

zhanghaohit
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix SSD table addreplica is failure #2026

  • What is the current behavior? (You can also link to an open issue here)
    Currently the storage_mode is not passed when sending snapshot. Thus the follower tablet copies the data into the wrong directory.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #2036 (220cf7d) into main (84bee03) will increase coverage by 0.11%.
The diff coverage is 92.43%.

@@             Coverage Diff              @@
##               main    #2036      +/-   ##
============================================
+ Coverage     75.58%   75.69%   +0.11%     
  Complexity      347      347              
============================================
  Files           609      615       +6     
  Lines        116384   116903     +519     
  Branches       1019     1015       -4     
============================================
+ Hits          87968    88491     +523     
+ Misses        28207    28203       -4     
  Partials        209      209              
Impacted Files Coverage Δ
src/tablet/tablet_impl.cc 60.07% <75.00%> (+0.71%) ⬆️
src/replica/snapshot_replica_test.cc 91.56% <92.79%> (+0.37%) ⬆️
src/client/tablet_client.cc 55.48% <100.00%> (+0.04%) ⬆️
src/tablet/file_sender.cc 69.56% <100.00%> (+6.32%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
hybridse/src/udf/udf_test.h 88.67% <0.00%> (-3.78%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 69.97% <0.00%> (-0.81%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bee03...220cf7d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

SDK Test Report

  75 files    75 suites   7m 19s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 220cf7d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

Linux Test Report

       54 files       196 suites   52m 46s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 220cf7d.

♻️ This comment has been updated with latest results.

@zhanghaohit zhanghaohit merged commit 094a424 into 4paradigm:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSD table addreplica is failure
3 participants