-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send snapshot for disk table #2036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
openmldb storage engine. nameserver & tablet
label
Jun 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #2036 +/- ##
============================================
+ Coverage 75.58% 75.69% +0.11%
Complexity 347 347
============================================
Files 609 615 +6
Lines 116384 116903 +519
Branches 1019 1015 -4
============================================
+ Hits 87968 88491 +523
+ Misses 28207 28203 -4
Partials 209 209
Continue to review full report at Codecov.
|
dl239
approved these changes
Jun 28, 2022
zhanghaohit
commented
Jun 29, 2022
aceforeverd
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix SSD table addreplica is failure #2026
What is the current behavior? (You can also link to an open issue here)
Currently the
storage_mode
is not passed when sending snapshot. Thus the follower tablet copies the data into the wrong directory.