Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new built-in aggregate function median #2030

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

wuxiaobai24
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add a new build-in aggregate function median.

  • What is the current behavior? (You can also link to an open issue here)
    It should resolve feat: new built-in aggregate function median #1960

  • What is the new behavior (if this is a feature change)?
    a new build-in aggregate function median.

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

SDK Test Report

  75 files    75 suites   6m 16s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 53053fa.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2030 (53053fa) into main (af0272c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2030      +/-   ##
============================================
+ Coverage     75.57%   75.59%   +0.01%     
  Complexity      347      347              
============================================
  Files           609      609              
  Lines        116409   116463      +54     
  Branches       1015     1015              
============================================
+ Hits          87974    88036      +62     
+ Misses        28226    28218       -8     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/udf/default_udf_library.cc 96.83% <100.00%> (+0.13%) ⬆️
hybridse/src/udf/default_udf_library_test.cc 100.00% <100.00%> (ø)
hybridse/src/udf/udaf_test.cc 100.00% <100.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client_test.cc 98.86% <0.00%> (-1.14%) ⬇️
src/catalog/tablet_catalog.cc 70.77% <0.00%> (-0.81%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0272c...53053fa. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

HybridSE Linux Test Report

19 100 tests   19 098 ✔️  6m 0s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 53053fa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

HybridSE Mac Test Report

19 100 tests   19 098 ✔️  6m 29s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 53053fa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

Linux Test Report

       54 files       196 suites   51m 27s ⏱️
  9 003 tests   8 999 ✔️ 4 💤 0
13 254 runs  13 250 ✔️ 4 💤 0

Results for commit 53053fa.

♻️ This comment has been updated with latest results.

hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Show resolved Hide resolved
@zhanghaohit zhanghaohit self-requested a review June 24, 2022 11:55
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wuxiaobai24 for the contribution!

@aceforeverd aceforeverd merged commit 90e7e9f into 4paradigm:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine udf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: new built-in aggregate function median
3 participants