Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the workflow to release the installing package for macos #2028

Merged
merged 8 commits into from
Jun 28, 2022
Merged

feat: add the workflow to release the installing package for macos #2028

merged 8 commits into from
Jun 28, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    Fixed Auto release the installing package of macos  #1894

  • What is the new behavior (if this is a feature change)?
    None

…omatically when a new tag created

Signed-off-by: mango <[email protected]>
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/cicd.yaml Show resolved Hide resolved
@mangoGoForward mangoGoForward marked this pull request as draft June 23, 2022 09:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

Linux Test Report

       54 files       196 suites   51m 9s ⏱️
  9 003 tests   8 999 ✔️ 4 💤 0
13 254 runs  13 250 ✔️ 4 💤 0

Results for commit a914b54.

♻️ This comment has been updated with latest results.

@mangoGoForward mangoGoForward marked this pull request as ready for review June 23, 2022 09:24
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2028 (a914b54) into main (b78fb44) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               main    #2028    +/-   ##
==========================================
  Coverage     75.60%   75.60%            
  Complexity      347      347            
==========================================
  Files           612      609     -3     
  Lines        116926   116463   -463     
  Branches       1022     1015     -7     
==========================================
- Hits          88404    88055   -349     
+ Misses        28313    28199   -114     
  Partials        209      209            
Impacted Files Coverage Δ
src/codec/field_codec.h 16.66% <0.00%> (-28.93%) ⬇️
hybridse/src/udf/udf_test.h 88.67% <0.00%> (-3.78%) ⬇️
src/catalog/tablet_catalog.cc 70.77% <0.00%> (-3.00%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.48%) ⬇️
hybridse/src/codegen/udf_ir_builder.cc 82.62% <0.00%> (-0.31%) ⬇️
src/tablet/tablet_impl.cc 59.35% <0.00%> (-0.23%) ⬇️
hybridse/include/codec/list_iterator_codec.h 80.85% <0.00%> (-0.21%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 60.98% <0.00%> (-0.17%) ⬇️
hybridse/src/vm/runner.cc 67.73% <0.00%> (-0.08%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78fb44...a914b54. Read the comment docs.

@aceforeverd
Copy link
Collaborator

Github workflow fails itself 🥲

@mangoGoForward
Copy link
Contributor Author

Github workflow fails itself 🥲

Too strange, and I was confused why this pr has no checks yesterday

@mangoGoForward mangoGoForward marked this pull request as draft June 24, 2022 09:42
@mangoGoForward mangoGoForward marked this pull request as ready for review June 24, 2022 09:45
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

SDK Test Report

  75 files    75 suites   6m 11s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit a914b54.

♻️ This comment has been updated with latest results.

@mangoGoForward
Copy link
Contributor Author

@aceforeverd The CI of macos-cpp and macos-release has been skipped, because only push a tag can trigger the flow.
but we can see the graph, it is seems right?
https://github.com/4paradigm/OpenMLDB/actions/runs/2554887555

image

@aceforeverd
Copy link
Collaborator

@aceforeverd The CI of macos-cpp and macos-release has been skipped, because only push a tag can trigger the flow. but we can see the graph, it is seems right? https://github.com/4paradigm/OpenMLDB/actions/runs/2554887555

image

yes, it is the expected behavior for pull request. No worry I will test the release logic later today

@mangoGoForward
Copy link
Contributor Author

yes, it is the expected behavior for pull request. No worry I will test the release logic later today

OK

Signed-off-by: mango <[email protected]>
Copy link
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and goes well. Thanks for being patient !

@aceforeverd aceforeverd added the workflow CICD related label Jun 28, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 38b1e9b into 4paradigm:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto release the installing package of macos
4 participants