-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support coverage ci for python sdk #2025
feat: support coverage ci for python sdk #2025
Conversation
Signed-off-by: mango <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2025 +/- ##
============================================
+ Coverage 75.60% 75.67% +0.06%
Complexity 347 347
============================================
Files 612 615 +3
Lines 116926 116739 -187
Branches 1022 1015 -7
============================================
- Hits 88404 88337 -67
+ Misses 28313 28193 -120
Partials 209 209
Continue to review full report at Codecov.
|
Signed-off-by: mango <[email protected]>
Signed-off-by: mango <[email protected]>
Hi @aceforeverd , the step of generate python coverage report failed, seems |
Yes it dumps, should use Lines 24 to 25 in af0272c
|
should use
Thanks so much. |
also test_python requires you to start the openmldb cluster, so I think you can just add a few coverage lines into |
Signed-off-by: mango <[email protected]>
Hi @aceforeverd , the CI of |
nice work. I see the coverage report but saidly it only show files in |
Signed-off-by: mango <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: mango [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
fixed test: add coverage report for python sdk #1971
What is the new behavior (if this is a feature change)?
None