Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move implement of function to cc #2017

Merged
merged 2 commits into from
Jun 22, 2022
Merged

refactor: move implement of function to cc #2017

merged 2 commits into from
Jun 22, 2022

Conversation

mangoGoForward
Copy link
Contributor

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2017 (2b0fc62) into main (855bb52) will decrease coverage by 0.01%.
The diff coverage is 30.76%.

@@             Coverage Diff              @@
##               main    #2017      +/-   ##
============================================
- Coverage     75.61%   75.60%   -0.02%     
  Complexity      347      347              
============================================
  Files           612      612              
  Lines        116943   116926      -17     
  Branches       1022     1022              
============================================
- Hits          88425    88398      -27     
- Misses        28309    28319      +10     
  Partials        209      209              
Impacted Files Coverage Δ
src/catalog/tablet_catalog.h 58.46% <ø> (+7.91%) ⬆️
src/catalog/tablet_catalog.cc 70.77% <30.76%> (-3.00%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.h 95.45% <0.00%> (-4.55%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/sdk/db_sdk.cc 63.90% <0.00%> (-0.45%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.cc 97.05% <0.00%> (-0.15%) ⬇️
src/tablet/tablet_impl.cc 59.35% <0.00%> (-0.10%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (-0.10%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855bb52...2b0fc62. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 49s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 2b0fc62.

@github-actions
Copy link
Contributor

Linux Test Report

       56 files       195 suites   49m 30s ⏱️
  8 958 tests   8 954 ✔️ 4 💤 0
13 184 runs  13 180 ✔️ 4 💤 0

Results for commit 2b0fc62.

@dl239 dl239 merged commit a7e8d69 into 4paradigm:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the implement of function from src/catalog/tablet_catalog.h to src/catalog/tablet_catalog.cc
3 participants