Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move in return stmt preventing copy elision #2012

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

CuriousCorrelation
Copy link
Contributor

@CuriousCorrelation CuriousCorrelation commented Jun 21, 2022

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

Linux Test Report

       56 files       195 suites   50m 20s ⏱️
  8 958 tests   8 954 ✔️ 4 💤 0
13 184 runs  13 180 ✔️ 4 💤 0

Results for commit 259f7dc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

HybridSE Linux Test Report

19 091 tests   19 089 ✔️  5m 27s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 259f7dc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

SDK Test Report

  75 files    75 suites   5m 44s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 259f7dc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

HybridSE Mac Test Report

19 091 tests   19 089 ✔️  6m 35s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 259f7dc.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2012 (259f7dc) into main (855bb52) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2012      +/-   ##
============================================
- Coverage     75.61%   75.59%   -0.02%     
  Complexity      347      347              
============================================
  Files           612      612              
  Lines        116943   116924      -19     
  Branches       1022     1022              
============================================
- Hits          88425    88391      -34     
- Misses        28309    28324      +15     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/include/codec/list_iterator_codec.h 80.85% <100.00%> (-0.21%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.h 95.45% <0.00%> (-4.55%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/sdk/db_sdk.cc 63.90% <0.00%> (-0.45%) ⬇️
src/tablet/tablet_impl.cc 59.30% <0.00%> (-0.15%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.cc 97.05% <0.00%> (-0.15%) ⬇️
hybridse/src/codegen/fn_let_ir_builder.cc 95.34% <0.00%> (-0.08%) ⬇️
hybridse/src/vm/runner.cc 67.73% <0.00%> (-0.04%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855bb52...259f7dc. Read the comment docs.

@dl239 dl239 merged commit 41c9de8 into 4paradigm:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return unique_ptr directly in GetIterator
3 participants