-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move in return stmt preventing copy elision #2012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceforeverd
reviewed
Jun 22, 2022
dl239
approved these changes
Jun 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #2012 +/- ##
============================================
- Coverage 75.61% 75.59% -0.02%
Complexity 347 347
============================================
Files 612 612
Lines 116943 116924 -19
Branches 1022 1022
============================================
- Hits 88425 88391 -34
- Misses 28309 28324 +15
Partials 209 209
Continue to review full report at Codecov.
|
aceforeverd
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes Return unique_ptr directly in
GetIterator
#2004Follows suggestion from the issue desc.
What is the current behavior?
Move prevents copy elision
https://pvs-studio.com/en/docs/warnings/v828/
https://en.cppreference.com/w/cpp/language/copy_elision
What is the new behavior?
Copy Elision is guaranteed when an object is returned directly (>C++17)