fix(codegen): loop combing should not reuse same count value for different columns #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contains null use a list of count instead single count variable to indicate whether the corresponding output of column should be null
this is also part of 4paradigm#1586
Codecov Report
@@ Coverage Diff @@
## main #1997 +/- ##
============================================
+ Coverage 75.62% 75.64% +0.02%
Complexity 347 347
============================================
Files 614 614
Lines 116995 116978 -17
Branches 1022 1022
============================================
+ Hits 88474 88486 +12
+ Misses 28312 28283 -29
Partials 209 209
Continue to review full report at Codecov.
|
aceforeverd
changed the title
min/max/avg/sum/count should not reuse same count value for different columns
aceforeverd
changed the title
min/max/avg/sum/count should not reuse same count value for different columns
dl239
reviewed
Jun 21, 2022
dl239
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window rows between 0 preceding and 2 precedingshould report compile error #1951sum/sum_where/avg/avg_whereshould return NULL if no rows in range or all values is NULL #1586What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?