Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genDDL function will generate incorrect ddl if partition by multi columns #1956

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 13, 2022

fix #1947

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 13, 2022
@dl239 dl239 changed the title fix: fix genDDL fix: genDDL function will generate incorrect ddl if column_key has multi column names Jun 13, 2022
@dl239 dl239 changed the title fix: genDDL function will generate incorrect ddl if column_key has multi column names fix: genDDL function will generate incorrect ddl if partition by multi columns Jun 13, 2022
@dl239 dl239 added the bug Something isn't working label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1956 (fbbea72) into main (607f32b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1956      +/-   ##
============================================
- Coverage     75.66%   75.61%   -0.05%     
  Complexity      347      347              
============================================
  Files           613      614       +1     
  Lines        117151   116969     -182     
  Branches       1025     1025              
============================================
- Hits          88643    88450     -193     
- Misses        28299    28310      +11     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/sql_router.cc 3.14% <0.00%> (+0.02%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-3.53%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (-0.13%) ⬇️
src/tablet/tablet_impl_test.cc 99.51% <0.00%> (-0.03%) ⬇️
src/storage/mem_table.cc 89.38% <0.00%> (-0.02%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607f32b...fbbea72. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   7m 54s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit fbbea72.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       196 suites   50m 22s ⏱️
  8 941 tests   8 937 ✔️ 4 💤 0
13 157 runs  13 153 ✔️ 4 💤 0

Results for commit fbbea72.

Copy link
Collaborator

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GenDDL part is cryptic, and very little testing. We should refactor and add tests later.

@dl239 dl239 merged commit 7717523 into 4paradigm:main Jun 14, 2022
@dl239 dl239 deleted the fix/gen_ddl branch June 14, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In some cases, the request result obtained by the procedure obtained through deploy is incorrect
3 participants