-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: genDDL
function will generate incorrect ddl if partition by multi columns
#1956
Conversation
genDDL
genDDL
function will generate incorrect ddl if column_key has multi column names
genDDL
function will generate incorrect ddl if column_key has multi column namesgenDDL
function will generate incorrect ddl if partition by multi columns
Codecov Report
@@ Coverage Diff @@
## main #1956 +/- ##
============================================
- Coverage 75.66% 75.61% -0.05%
Complexity 347 347
============================================
Files 613 614 +1
Lines 117151 116969 -182
Branches 1025 1025
============================================
- Hits 88643 88450 -193
- Misses 28299 28310 +11
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenDDL part is cryptic, and very little testing. We should refactor and add tests later.
fix #1947