Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename session_timeout to zk_session_timeout in clusteroptions #1953

Merged
merged 3 commits into from
Jun 14, 2022
Merged

refactor: rename session_timeout to zk_session_timeout in clusteroptions #1953

merged 3 commits into from
Jun 14, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Refactor: rename session_timeout to zk_session_timeout

  • What is the current behavior? (You can also link to an open issue here)
    Resolved refactor: rename zk session_timeout in db sdk #1940

  • What is the new behavior (if this is a feature change)?
    None

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jun 13, 2022
@aceforeverd aceforeverd added the good first issue Good for newcomers label Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

SDK Test Report

  75 files    75 suites   6m 49s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit bd212c9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

HybridSE Linux Test Report

19 076 tests   19 074 ✔️  5m 27s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit bd212c9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

HybridSE Mac Test Report

19 076 tests   19 074 ✔️  6m 38s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit bd212c9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

Linux Test Report

       57 files       196 suites   50m 7s ⏱️
  8 941 tests   8 937 ✔️ 4 💤 0
13 157 runs  13 153 ✔️ 4 💤 0

Results for commit bd212c9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1953 (bd212c9) into main (79b3450) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #1953      +/-   ##
============================================
- Coverage     75.63%   75.59%   -0.04%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        116976   116977       +1     
  Branches       1025     1022       -3     
============================================
- Hits          88471    88430      -41     
- Misses        28296    28338      +42     
  Partials        209      209              
Impacted Files Coverage Δ
...dse/src/passes/physical/group_and_sort_optimized.h 100.00% <ø> (ø)
src/cmd/sql_cmd.h 26.71% <0.00%> (ø)
hybridse/src/testing/test_base.cc 88.47% <100.00%> (ø)
src/sdk/db_sdk.cc 63.47% <100.00%> (-0.61%) ⬇️
src/sdk/db_sdk.h 92.68% <100.00%> (+0.18%) ⬆️
src/sdk/sql_cluster_router.cc 54.92% <100.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/zk_client.cc 82.85% <0.00%> (-1.04%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3450...bd212c9. Read the comment docs.

@aceforeverd
Copy link
Collaborator

@mangoGoForward
Copy link
Contributor Author

@vagetablechicken conflict change: https://github.com/4paradigm/OpenMLDB/runs/6873399635?check_suite_focus=true#step:8:224

Pull and solved.

@dl239 dl239 merged commit 19ab600 into 4paradigm:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: rename zk session_timeout in db sdk
4 participants