Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to make sure c row is released for UnsafeRowOpt #1943

Merged

Conversation

tobegit3hub
Copy link
Collaborator

  • Refactor the code of row release

@tobegit3hub tobegit3hub self-assigned this Jun 9, 2022
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Jun 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

SDK Test Report

  75 files    75 suites   6m 24s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 0754707.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1943 (0754707) into main (282ce34) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1943      +/-   ##
============================================
- Coverage     75.64%   75.61%   -0.04%     
  Complexity      347      347              
============================================
  Files           613      614       +1     
  Lines        117144   116970     -174     
  Branches       1025     1022       -3     
============================================
- Hits          88617    88443     -174     
  Misses        28318    28318              
  Partials        209      209              
Impacted Files Coverage Δ
...paradigm/openmldb/batch/nodes/RowProjectPlan.scala 82.52% <ø> (-0.17%) ⬇️
...aradigm/openmldb/batch/window/WindowComputer.scala 81.00% <ø> (-0.19%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 61.15% <50.00%> (+0.10%) ⬆️
...4paradigm/openmldb/batch/utils/UnsafeRowUtil.scala 84.21% <100.00%> (+0.87%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/sdk/db_sdk.cc 63.49% <0.00%> (-1.14%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-0.89%) ⬇️
src/zk/zk_client.cc 84.33% <0.00%> (-0.27%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282ce34...0754707. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Linux Test Report

       57 files       196 suites   50m 2s ⏱️
  8 941 tests   8 937 ✔️ 4 💤 0
13 157 runs  13 153 ✔️ 4 💤 0

Results for commit 0754707.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub merged commit 24c8139 into 4paradigm:main Jun 14, 2022
@tobegit3hub
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants