Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zk log options & flags fix #1938

Merged
merged 5 commits into from
Jun 14, 2022

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Jun 9, 2022

Closes #1500
CLI: disable zk log by default(log level 0). use gflags zk_log_level & zk_log_file to modify ClusterOptions.
other sdk: use default ClusterOptions now, info level and use stream stderr(default in zk).

make more flag desc.

disable zk log by default.
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1938 (b5ef04a) into main (6525d83) will decrease coverage by 0.14%.
The diff coverage is 68.18%.

@@             Coverage Diff              @@
##               main    #1938      +/-   ##
============================================
- Coverage     75.77%   75.62%   -0.15%     
  Complexity      347      347              
============================================
  Files           613      614       +1     
  Lines        117624   116976     -648     
  Branches       1025     1025              
============================================
- Hits          89125    88463     -662     
- Misses        28290    28304      +14     
  Partials        209      209              
Impacted Files Coverage Δ
src/cmd/sql_cmd.h 26.71% <0.00%> (-0.63%) ⬇️
src/zk/zk_client.h 100.00% <ø> (ø)
src/zk/zk_client.cc 83.37% <66.66%> (-0.18%) ⬇️
src/sdk/db_sdk.cc 66.59% <80.00%> (+2.64%) ⬆️
src/sdk/db_sdk.h 92.50% <100.00%> (+1.07%) ⬆️
src/storage/schema.h 84.55% <0.00%> (-4.88%) ⬇️
src/storage/schema.cc 77.43% <0.00%> (-4.27%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/nameserver/name_server_test.cc 91.81% <0.00%> (-0.47%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6525d83...b5ef04a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

SDK Test Report

  75 files    75 suites   5m 16s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit b5ef04a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Linux Test Report

       57 files       196 suites   51m 45s ⏱️
  8 941 tests   8 937 ✔️ 4 💤 0
13 157 runs  13 153 ✔️ 4 💤 0

Results for commit b5ef04a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken changed the title feat: support zk log options feat: support zk log options & flags fix Jun 9, 2022
@vagetablechicken vagetablechicken marked this pull request as ready for review June 10, 2022 02:07
@vagetablechicken vagetablechicken enabled auto-merge (squash) June 10, 2022 02:07
@vagetablechicken vagetablechicken enabled auto-merge (squash) June 10, 2022 02:07
src/zk/zk_client.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql_client: zk "exceeded deadline by N ms" floods logs
3 participants