-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support zk log options & flags fix #1938
Conversation
disable zk log by default.
Codecov Report
@@ Coverage Diff @@
## main #1938 +/- ##
============================================
- Coverage 75.77% 75.62% -0.15%
Complexity 347 347
============================================
Files 613 614 +1
Lines 117624 116976 -648
Branches 1025 1025
============================================
- Hits 89125 88463 -662
- Misses 28290 28304 +14
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1500
CLI: disable zk log by default(log level 0). use gflags zk_log_level & zk_log_file to modify
ClusterOptions
.other sdk: use default
ClusterOptions
now, info level and use stream stderr(default in zk).make more flag desc.