Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm format_version in put #1913

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented May 31, 2022

No description provided.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 31, 2022
@dl239 dl239 linked an issue May 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1913 (b1e60b3) into main (908e9ed) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1913      +/-   ##
============================================
+ Coverage     75.69%   75.74%   +0.04%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117059   117335     +276     
  Branches       1024     1009      -15     
============================================
+ Hits          88613    88870     +257     
- Misses        28237    28256      +19     
  Partials        209      209              
Impacted Files Coverage Δ
src/client/tablet_client.cc 54.91% <100.00%> (-0.21%) ⬇️
src/sdk/sql_cluster_router.cc 55.09% <100.00%> (+0.24%) ⬆️
src/tablet/tablet_impl.cc 59.22% <100.00%> (-0.05%) ⬇️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 77.14% <0.00%> (-7.29%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 61.04% <0.00%> (-2.83%) ⬇️
src/storage/aggregator_test.cc 94.55% <0.00%> (-2.05%) ⬇️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 60.00% <0.00%> (-0.98%) ⬇️
src/catalog/tablet_catalog.cc 73.77% <0.00%> (-0.87%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.32%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908e9ed...b1e60b3. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 48s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit b1e60b3.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       193 suites   1h 1m 46s ⏱️
  8 676 tests   8 672 ✔️ 4 💤 0
12 747 runs  12 743 ✔️ 4 💤 0

Results for commit b1e60b3.

@vagetablechicken vagetablechicken merged commit d6d6986 into 4paradigm:main Jun 1, 2022
@dl239 dl239 deleted the refact/put_format_version branch June 1, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete format_version from Put function
3 participants