Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: catch and throw unsupported exception for SparkSQL fallback #1908

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added this to the v0.6 milestone May 31, 2022
@tobegit3hub tobegit3hub self-assigned this May 31, 2022
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1908 (26a9097) into main (250da4e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #1908   +/-   ##
=========================================
  Coverage     75.70%   75.71%           
  Complexity      347      347           
=========================================
  Files           613      613           
  Lines        117112   117119    +7     
  Branches       1009     1025   +16     
=========================================
+ Hits          88655    88671   +16     
+ Misses        28248    28239    -9     
  Partials        209      209           
Impacted Files Coverage Δ
...in/java/com/_4paradigm/hybridse/sdk/SqlEngine.java 56.06% <0.00%> (-5.61%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.30% <0.00%> (-0.31%) ⬇️
hybridse/include/base/spin_lock.h 66.66% <0.00%> (-33.34%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/tablet/tablet_impl.cc 59.29% <0.00%> (-0.03%) ⬇️
src/nameserver/name_server_impl.cc 42.88% <0.00%> (+0.01%) ⬆️
hybridse/src/vm/runner.cc 67.78% <0.00%> (+0.03%) ⬆️
src/client/tablet_client.cc 55.22% <0.00%> (+0.11%) ⬆️
src/sdk/sql_cluster_router.cc 55.14% <0.00%> (+0.29%) ⬆️
hybridse/src/codec/fe_row_codec.cc 78.64% <0.00%> (+0.31%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250da4e...26a9097. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   5m 43s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 26a9097.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       193 suites   1h 2m 34s ⏱️
  8 673 tests   8 669 ✔️ 4 💤 0
12 744 runs  12 740 ✔️ 4 💤 0

Results for commit 26a9097.

@aceforeverd
Copy link
Collaborator

Bugs (0.5.x)

@tobegit3hub tobegit3hub merged commit 0083ac9 into 4paradigm:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to catch UnsupportedHybridSeException and fallback to SparkSQL with OpenMLDB Spark distribution
3 participants