Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: built-in-function: support char(int) function #817 #1896

Merged
merged 34 commits into from
May 31, 2022

Conversation

Ivyee17
Copy link
Contributor

@Ivyee17 Ivyee17 commented May 27, 2022

Close #817

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

Linux Test Report

       57 files       193 suites   1h 3m 17s ⏱️
  8 673 tests   8 669 ✔️ 4 💤 0
12 744 runs  12 740 ✔️ 4 💤 0

Results for commit eb0119f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

HybridSE Linux Test Report

       67 files       235 suites   5m 33s ⏱️
19 062 tests 19 060 ✔️ 2 💤 0

Results for commit eb0119f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 38s ⏱️
19 062 tests 19 060 ✔️ 2 💤 0

Results for commit eb0119f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

SDK Test Report

  75 files    75 suites   6m 16s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit eb0119f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1896 (eb0119f) into main (908e9ed) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1896      +/-   ##
============================================
- Coverage     75.69%   75.69%   -0.01%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117059   117080      +21     
  Branches       1024     1008      -16     
============================================
+ Hits          88613    88621       +8     
- Misses        28237    28250      +13     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/udf/udf.h 100.00% <ø> (ø)
hybridse/src/codegen/udf_ir_builder_test.cc 99.47% <100.00%> (+<0.01%) ⬆️
hybridse/src/udf/default_udf_library.cc 96.47% <100.00%> (+0.01%) ⬆️
hybridse/src/udf/udf.cc 84.91% <100.00%> (+0.16%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/catalog/tablet_catalog.cc 73.77% <0.00%> (-0.87%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.32%) ⬇️
src/nameserver/name_server_impl.cc 42.74% <0.00%> (-0.11%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908e9ed...eb0119f. Read the comment docs.

hybridse/src/codegen/udf_ir_builder_test.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/codegen/udf_ir_builder_test.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
@aceforeverd aceforeverd added good first issue Good for newcomers udf labels May 27, 2022
@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 27, 2022

cicd/cpp CI is down. maybe need to restart? @aceforeverd

@Ivyee17 Ivyee17 requested a review from aceforeverd May 27, 2022 12:23
@aceforeverd aceforeverd requested a review from zhanghaohit May 28, 2022 08:15
@aceforeverd
Copy link
Collaborator

Pls resolve merge conflicts

hybridse/src/udf/udf.cc Show resolved Hide resolved
hybridse/src/codegen/udf_ir_builder_test.cc Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
@zhanghaohit zhanghaohit self-requested a review May 30, 2022 07:39
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 30, 2022

cicd/cpp is down because the DBSDK is failed to init (for connection problem or sth. else?). may need to restart this CI?

Log:
E0530 09:35:52.121150 13344 name_server_impl.cc:10790] ERROR: Failed to init DBSDK

hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
hybridse/src/codegen/udf_ir_builder_test.cc Outdated Show resolved Hide resolved
@aceforeverd
Copy link
Collaborator

cicd/cpp is down because the DBSDK is failed to init (for connection problem or sth. else?). may need to restart this CI?

Log: E0530 09:35:52.121150 13344 name_server_impl.cc:10790] ERROR: Failed to init DBSDK

This was because of machine resource limitation, no worry

@aceforeverd aceforeverd changed the title fix: built-in-function: support char(int) function #817 feat: built-in-function: support char(int) function #817 May 30, 2022
@Ivyee17 Ivyee17 requested a review from aceforeverd May 30, 2022 17:42
@aceforeverd aceforeverd merged commit c512a82 into 4paradigm:main May 31, 2022
@aceforeverd aceforeverd added this to the v0.6 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine good first issue Good for newcomers udf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built-in-function: Support char(int) function
3 participants