-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: built-in function: support char_length() and character_length() function #1895
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1895 +/- ##
============================================
- Coverage 75.71% 75.69% -0.03%
Complexity 347 347
============================================
Files 613 613
Lines 117043 117059 +16
Branches 1024 1024
============================================
- Hits 88621 88605 -16
- Misses 28213 28245 +32
Partials 209 209
Continue to review full report at Codecov.
|
The reason of coverage decreasing is a check of null in stringref. I do think that it’s a better choice to add it in the code even if it is not coveraged. |
It's ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pls resolve the merge conflicts |
Oops.. still the coverage problem..
|
close #818