Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: built-in function: support char_length() and character_length() function #1895

Merged
merged 21 commits into from
May 28, 2022

Conversation

Ivyee17
Copy link
Contributor

@Ivyee17 Ivyee17 commented May 26, 2022

close #818

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 26, 2022
@Ivyee17 Ivyee17 changed the title built-in function: support char_length() and character_length() function fix: built-in function: support char_length() and character_length() function May 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

SDK Test Report

  75 files    75 suites   6m 8s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 59d47a5.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1895 (59d47a5) into main (57b5308) will decrease coverage by 0.02%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##               main    #1895      +/-   ##
============================================
- Coverage     75.71%   75.69%   -0.03%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117043   117059      +16     
  Branches       1024     1024              
============================================
- Hits          88621    88605      -16     
- Misses        28213    28245      +32     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/udf/udf.h 100.00% <ø> (ø)
hybridse/src/udf/udf.cc 84.74% <80.00%> (-0.04%) ⬇️
hybridse/src/codegen/udf_ir_builder_test.cc 99.46% <100.00%> (+<0.01%) ⬆️
hybridse/src/udf/default_udf_library.cc 96.45% <100.00%> (+0.01%) ⬆️
hybridse/include/base/spin_lock.h 66.66% <0.00%> (-33.34%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
hybridse/src/codec/type_codec.cc 74.40% <0.00%> (-1.43%) ⬇️
src/catalog/tablet_catalog.cc 72.91% <0.00%> (-0.87%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b5308...59d47a5. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

HybridSE Linux Test Report

       67 files       235 suites   6m 17s ⏱️
19 061 tests 19 059 ✔️ 2 💤 0

Results for commit 59d47a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 15s ⏱️
19 061 tests 19 059 ✔️ 2 💤 0

Results for commit 59d47a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

Linux Test Report

       57 files       193 suites   1h 2m 52s ⏱️
  8 673 tests   8 669 ✔️ 4 💤 0
12 744 runs  12 740 ✔️ 4 💤 0

Results for commit 59d47a5.

♻️ This comment has been updated with latest results.

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 27, 2022

The reason of coverage decreasing is a check of null in stringref. I do think that it’s a better choice to add it in the code even if it is not coveraged.

@aceforeverd aceforeverd added good first issue Good for newcomers udf labels May 27, 2022
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.h Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Show resolved Hide resolved
hybridse/src/codegen/udf_ir_builder_test.cc Show resolved Hide resolved
@aceforeverd
Copy link
Collaborator

The reason of coverage decreasing is a check of null in stringref. I do think that it’s a better choice to add it in the code even if it is not coveraged.

It's ok

hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
@zhanghaohit zhanghaohit self-requested a review May 27, 2022 11:36
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd
Copy link
Collaborator

Pls resolve the merge conflicts

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 28, 2022

Oops.. still the coverage problem..

The reason of coverage decreasing is a check of null in stringref. I do think that it’s a better choice to add it in the code even if it is not coveraged.

It's ok

@aceforeverd aceforeverd merged commit 908e9ed into 4paradigm:main May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine good first issue Good for newcomers udf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built-in function: Support char_length() and character_length() function
3 participants