Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove sscan and sget command in tablet client #1886

Merged
merged 1 commit into from
May 26, 2022
Merged

refactor: remove sscan and sget command in tablet client #1886

merged 1 commit into from
May 26, 2022

Conversation

frazie
Copy link
Contributor

@frazie frazie commented May 25, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    deletion of unused functions

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1886 (cb2e890) into main (50d0699) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1886      +/-   ##
============================================
- Coverage     75.76%   75.68%   -0.09%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117018   117018              
  Branches       1024     1024              
============================================
- Hits          88663    88567      -96     
- Misses        28146    28242      +96     
  Partials        209      209              
Impacted Files Coverage Δ
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/sdk/db_sdk.cc 62.58% <0.00%> (-6.58%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/tablet/tablet_impl.cc 59.34% <0.00%> (-0.47%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d0699...cb2e890. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   7m 59s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit cb2e890.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       187 suites   1h 2m 1s ⏱️
  8 503 tests   8 499 ✔️ 4 💤 0
12 489 runs  12 485 ✔️ 4 💤 0

Results for commit cb2e890.

@aceforeverd aceforeverd added the good first issue Good for newcomers label May 26, 2022
@aceforeverd aceforeverd added this to the v0.6 milestone May 26, 2022
@dl239 dl239 changed the title Remove sscan and sget command in tablet client #1881 refactor: remove sscan and sget command in tablet client #1881 May 26, 2022
@dl239 dl239 changed the title refactor: remove sscan and sget command in tablet client #1881 refactor: remove sscan and sget command in tablet client May 26, 2022
@dl239 dl239 linked an issue May 26, 2022 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 4cda032 into 4paradigm:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sscan and sget command in tablet client
5 participants