Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pylint check in github action #1873

Merged
merged 3 commits into from
May 25, 2022
Merged

feat: support pylint check in github action #1873

merged 3 commits into from
May 25, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    Resolved enable python style check via pylint #315

  • What is the new behavior (if this is a feature change)?
    support pylint check in github action

@github-actions github-actions bot added the workflow CICD related label May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1873 (fdf6614) into main (1a8db9f) will increase coverage by 1.93%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1873      +/-   ##
============================================
+ Coverage     73.76%   75.70%   +1.93%     
  Complexity      347      347              
============================================
  Files           615      613       -2     
  Lines        120391   117407    -2984     
  Branches       1021     1024       +3     
============================================
+ Hits          88809    88885      +76     
+ Misses        31373    28313    -3060     
  Partials        209      209              
Impacted Files Coverage Δ
...src/passes/expression/window_iter_analysis_test.cc 77.77% <0.00%> (-22.23%) ⬇️
hybridse/include/codec/row.h 80.00% <0.00%> (-14.12%) ⬇️
src/nameserver/system_table.cc 77.27% <0.00%> (-11.62%) ⬇️
src/catalog/distribute_iterator.cc 88.29% <0.00%> (-3.93%) ⬇️
hybridse/src/vm/physical_op.cc 79.33% <0.00%> (-2.00%) ⬇️
hybridse/src/node/sql_node.cc 79.79% <0.00%> (-1.07%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.48%) ⬇️
src/client/tablet_client.cc 49.53% <0.00%> (-0.32%) ⬇️
hybridse/src/vm/mem_catalog.cc 73.44% <0.00%> (-0.22%) ⬇️
hybridse/src/udf/udf_test.cc 98.18% <0.00%> (-0.19%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8db9f...fdf6614. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

SDK Test Report

  75 files    75 suites   7m 27s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit fdf6614.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Linux Test Report

       57 files       187 suites   1h 7m 3s ⏱️
  8 549 tests   8 541 ✔️ 8 💤 0
12 535 runs  12 527 ✔️ 8 💤 0

Results for commit fdf6614.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/style.yml Outdated Show resolved Hide resolved
pylintrc Outdated Show resolved Hide resolved
@aceforeverd aceforeverd self-requested a review May 25, 2022 06:55
@aceforeverd aceforeverd merged commit f836165 into 4paradigm:main May 25, 2022
@aceforeverd aceforeverd added this to the v0.6 milestone May 25, 2022
@mangoGoForward mangoGoForward deleted the feat/add-pylint-check branch June 2, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable python style check via pylint
3 participants