-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve the javadoc warning of openmldb-jdbc #1319 #1863
Conversation
Seems like the coverage test is fail because the disk is full or the problem in cache setting. Logs: I hope that this PR is correct, and if any questions, reply or contact me for free. |
java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/common/LibraryLoader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage test failed on network error. We'll rerun it later, don't worry.
Plz fix isTemp
desc.
Thanks to check this PR. I’ve already fixed it! |
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
============================================
- Coverage 73.74% 73.74% -0.01%
Complexity 347 347
============================================
Files 615 615
Lines 120382 120382
Branches 1021 1021
============================================
- Hits 88778 88777 -1
- Misses 31395 31396 +1
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #1319: #1319