Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the javadoc warning of openmldb-jdbc #1319 #1863

Merged
merged 3 commits into from
May 23, 2022

Conversation

Ivyee17
Copy link
Contributor

@Ivyee17 Ivyee17 commented May 21, 2022

close #1319: #1319

@github-actions github-actions bot added the sdk openmldb java/python sdk label May 21, 2022
@Ivyee17 Ivyee17 changed the title fix: Resolve the JavaDoc warning of openmldb-jdbc #1319 fix: resolve the JavaDoc warning of openmldb-jdbc #1319 May 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2022

SDK Test Report

  75 files    75 suites   8m 16s ⏱️
176 tests 173 ✔️ 3 💤 0
217 runs  214 ✔️ 3 💤 0

Results for commit 70bf462.

♻️ This comment has been updated with latest results.

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 21, 2022

Seems like the coverage test is fail because the disk is full or the problem in cache setting.

Logs:
curl: (18) transfer closed with 507344385 bytes remaining to read
Error: Process completed with exit code 18.

I hope that this PR is correct, and if any questions, reply or contact me for free.

@Ivyee17 Ivyee17 changed the title fix: resolve the JavaDoc warning of openmldb-jdbc #1319 fix: resolve the javadoc warning of openmldb-jdbc #1319 May 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2022

Linux Test Report

       57 files       186 suites   1h 6m 38s ⏱️
  8 543 tests   8 535 ✔️ 8 💤 0
12 529 runs  12 521 ✔️ 8 💤 0

Results for commit 70bf462.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage test failed on network error. We'll rerun it later, don't worry.

Plz fix isTemp desc.

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 22, 2022

The coverage test failed on network error. We'll rerun it later, don't worry.

Plz fix isTemp desc.

Thanks to check this PR. I’ve already fixed it!

@vagetablechicken vagetablechicken enabled auto-merge (squash) May 22, 2022 06:42
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #1863 (70bf462) into main (0a06919) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1863      +/-   ##
============================================
- Coverage     73.74%   73.74%   -0.01%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        120382   120382              
  Branches       1021     1021              
============================================
- Hits          88778    88777       -1     
- Misses        31395    31396       +1     
  Partials        209      209              
Impacted Files Coverage Δ
.../com/_4paradigm/openmldb/common/LibraryLoader.java 24.56% <ø> (ø)
...ava/com/_4paradigm/openmldb/jdbc/SQLResultSet.java 14.44% <ø> (ø)
.../java/com/_4paradigm/openmldb/sdk/QueryFuture.java 0.00% <ø> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/sdk/sql_cluster_router.cc 54.84% <0.00%> (-0.30%) ⬇️
src/nameserver/name_server_impl.cc 42.71% <0.00%> (-0.05%) ⬇️
src/zk/zk_client.cc 83.55% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cf175...70bf462. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit d1e35ce into 4paradigm:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve the JavaDoc warning of openmldb-jdbc
3 participants