Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support window union for cluster mode/request mode #1855

Merged

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented May 20, 2022

enable window union for cluster/request mode, close #1828

Though toydb_toydb_engine_test passes, it seems not properly emulate the cluster environment. We currently only test cluster/request case through sql_cluster_test. Standalone test in sql engine should be supported anyway later.

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels May 20, 2022
@aceforeverd aceforeverd self-assigned this May 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

SDK Test Report

  75 files    75 suites   6m 32s ⏱️
176 tests 173 ✔️ 3 💤 0
217 runs  214 ✔️ 3 💤 0

Results for commit 8cbbfa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

HybridSE Linux Test Report

       67 files       235 suites   6m 23s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 8cbbfa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 27s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 8cbbfa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

Linux Test Report

       57 files       187 suites   1h 7m 47s ⏱️
  8 549 tests   8 541 ✔️ 8 💤 0
12 535 runs  12 527 ✔️ 8 💤 0

Results for commit 8cbbfa7.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1855 (8cbbfa7) into main (b8ff05e) will increase coverage by 0.01%.
The diff coverage is 7.69%.

@@             Coverage Diff              @@
##               main    #1855      +/-   ##
============================================
+ Coverage     73.74%   73.76%   +0.01%     
  Complexity      347      347              
============================================
  Files           614      615       +1     
  Lines        120314   120394      +80     
  Branches       1015     1021       +6     
============================================
+ Hits          88731    88810      +79     
- Misses        31374    31375       +1     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/include/base/iterator.h 100.00% <ø> (ø)
hybridse/include/codec/row.h 80.00% <0.00%> (-14.12%) ⬇️
hybridse/src/vm/runner.cc 67.87% <ø> (+0.06%) ⬆️
src/catalog/distribute_iterator.cc 88.29% <0.00%> (-3.93%) ⬇️
src/catalog/distribute_iterator.h 60.00% <0.00%> (+8.27%) ⬆️
src/sdk/sql_cluster_router.cc 55.14% <100.00%> (+0.17%) ⬆️
hybridse/include/base/spin_lock.h 66.66% <0.00%> (-33.34%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ff05e...8cbbfa7. Read the comment docs.

@aceforeverd aceforeverd changed the title feat: window union cluster mode feat: support window union for cluster mode/request mode May 23, 2022
@aceforeverd
Copy link
Collaborator Author

@aceforeverd aceforeverd added this to the v0.6 milestone May 23, 2022
src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved
@zhanghaohit zhanghaohit self-requested a review May 24, 2022 02:34
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit a7370b4 into 4paradigm:main May 24, 2022
@aceforeverd aceforeverd deleted the feat-1828-window-union-cluster-mode branch May 24, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support window union over multiple input source in cluster mode & request mode
3 participants