-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support window union for cluster mode/request mode #1855
feat: support window union for cluster mode/request mode #1855
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1855 +/- ##
============================================
+ Coverage 73.74% 73.76% +0.01%
Complexity 347 347
============================================
Files 614 615 +1
Lines 120314 120394 +80
Branches 1015 1021 +6
============================================
+ Hits 88731 88810 +79
- Misses 31374 31375 +1
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
enable window union for cluster/request mode, close #1828
Though
toydb_toydb_engine_test
passes, it seems not properly emulate the cluster environment. We currently only test cluster/request case throughsql_cluster_test
. Standalone test in sql engine should be supported anyway later.