fix(#1761): explain require next <cr> and space ending problem #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
execute-engine
Codecov Report
@@ Coverage Diff @@
## main #1820 +/- ##
============================================
- Coverage 73.75% 73.74% -0.02%
Complexity 347 347
============================================
Files 614 614
Lines 120314 120324 +10
Branches 1015 1015
============================================
- Hits 88732 88727 -5
- Misses 31373 31388 +15
Partials 209 209
Continue to review full report at Codecov.
|
aceforeverd
changed the title
also removed the <tab> indent from physical_plan_str
aceforeverd
commented
May 17, 2022
| @@ -1969,6 +1969,27 @@ TEST_P(DBSDKTest, DeployStatsOnlyCollectDeployProcedure) { | |||
| } | |||
| } | |||
|
|
|||
| class StripSpaceTest : public ::testing::TestWithParam<std::pair<std::string_view, std::string_view>> {}; | |||
|
|
|||
| std::vector<std::pair<std::string_view, std::string_view>> strip_cases = { | |||
There was a problem hiding this comment.
how about "show\ncomponents\n;"
There was a problem hiding this comment.
statement str inside is handle by zetasql, should be fine.
anyway case like show components; set val = '; ' probably not work as expect
dl239
approved these changes
May 20, 2022
vagetablechicken
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1761
two problem in cli:
<CR>