Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define the ordering for rows having same key/ts in window union but from different datasource #1802

Merged
merged 7 commits into from
May 13, 2022

Conversation

aceforeverd
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #1776

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

SDK Test Report

  74 files    74 suites   5m 29s ⏱️
175 tests 172 ✔️ 3 💤 0
216 runs  213 ✔️ 3 💤 0

Results for commit 2d6f557.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Linux Test Report

       57 files       186 suites   1h 6m 55s ⏱️
  8 542 tests   8 534 ✔️ 8 💤 0
12 528 runs  12 520 ✔️ 8 💤 0

Results for commit 2d6f557.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

HybridSE Linux Test Report

       67 files       235 suites   6m 13s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 2d6f557.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 12s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 2d6f557.

♻️ This comment has been updated with latest results.

- window union not support in cluster mode
- define the explicit order for multiple union table rows with same ts
@aceforeverd aceforeverd changed the title fix: close #1776 fix: define the ordering for rows having same key/ts in window union but from different datasource May 12, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1802 (2d6f557) into main (361f44d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1802      +/-   ##
============================================
+ Coverage     73.64%   73.75%   +0.10%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120131   120314     +183     
  Branches       1015     1015              
============================================
+ Hits          88475    88742     +267     
+ Misses        31447    31363      -84     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/vm/runner.h 92.84% <ø> (ø)
hybridse/src/vm/runner.cc 67.81% <100.00%> (-0.07%) ⬇️
hybridse/src/codec/type_codec.cc 74.40% <0.00%> (-0.60%) ⬇️
src/sdk/db_sdk.cc 62.58% <0.00%> (-0.46%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/nameserver/name_server_create_remote_test.cc 98.70% <0.00%> (-0.19%) ⬇️
src/storage/mem_table.cc 89.13% <0.00%> (-0.14%) ⬇️
src/cmd/sql_cmd_test.cc 99.55% <0.00%> (-0.04%) ⬇️
src/nameserver/standalone_test.cc 100.00% <0.00%> (ø)
src/nameserver/name_server_test.cc 92.29% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...2d6f557. Read the comment docs.

@aceforeverd aceforeverd requested a review from zhanghaohit May 12, 2022 13:31
@zhanghaohit zhanghaohit merged commit 29bd02e into 4paradigm:main May 13, 2022
@aceforeverd aceforeverd deleted the fix/1776 branch May 13, 2022 03:09
@aceforeverd
Copy link
Collaborator Author

Bugs (Normal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window with union: ordering for union rows and original rows with the same order key is undefined
3 participants