-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define the ordering for rows having same key/ts in window union but from different datasource #1802
Conversation
union rows always be after originals rows, see 4paradigm#1776 (comment)
- window union not support in cluster mode - define the explicit order for multiple union table rows with same ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1802 +/- ##
============================================
+ Coverage 73.64% 73.75% +0.10%
Complexity 347 347
============================================
Files 614 614
Lines 120131 120314 +183
Branches 1015 1015
============================================
+ Hits 88475 88742 +267
+ Misses 31447 31363 -84
Partials 209 209
Continue to review full report at Codecov.
|
close #1776
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?