Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set the constant in getSQLStateType #1781

Merged
merged 1 commit into from
May 12, 2022
Merged

refactor: set the constant in getSQLStateType #1781

merged 1 commit into from
May 12, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • code update

  • What is the current behavior? (You can also link to an open issue here)

  • set the constant in getSQLStateType #1758

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the sdk openmldb java/python sdk label May 10, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  74 files    74 suites   7m 8s ⏱️
175 tests 172 ✔️ 3 💤 0 ❌
216 runs  213 ✔️ 3 💤 0 ❌

Results for commit 67eaa28.

@dl239 dl239 changed the title set the constant in getSQLStateType refactor: set the constant in getSQLStateType May 10, 2022
@dl239 dl239 linked an issue May 10, 2022 that may be closed by this pull request
set the constant in getSQLStateType #1758
Closed
@github-actions
Copy link
Contributor

Linux Test Report

       57 files       186 suites   1h 8m 21s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0 ❌
12 419 runs  12 411 ✔️ 8 💤 0 ❌

Results for commit 67eaa28.

@SaumyaBhushan
Copy link
Contributor Author

@vagetablechicken @dl239 Is this pull request ready to get merged?

tobegit3hub
tobegit3hub approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub
Copy link
Collaborator

Thanks for your contribution @SaumyaBhushan ✨

@tobegit3hub tobegit3hub merged commit 30ed2e1 into 4paradigm:main May 12, 2022
@SaumyaBhushan SaumyaBhushan deleted the Isuue#1758 branch May 12, 2022 13:03
@SaumyaBhushan
Copy link
Contributor Author

Thanks for your contribution @SaumyaBhushan sparkles

Happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dl239 dl239 dl239 approved these changes

@tobegit3hub tobegit3hub tobegit3hub approved these changes

@vagetablechicken vagetablechicken Awaiting requested review from vagetablechicken

Assignees
No one assigned
Labels
sdk openmldb java/python sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set the constant in getSQLStateType
3 participants
@SaumyaBhushan @tobegit3hub @dl239