-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix typo of PhysicalAggrerationNode #1779
Conversation
4paradigm#1770: In OpenMLDB/hybridse/src/passes/physical/split_aggregation_optimized.cc there are 7 instances where PhysicalAggrerationNode was replaced with PhysicalAggregationNode
4paradigm#1770: In OpenMLDB/hybridse/src/passes/physical/long_window_optimized.h , there was 1 instance in which PhysicalAggrerationNode was replaced to PhysicalAggregationNode
There were 9 instances in this file in which PhysicalAggrerationNode is replaced to PhysicalAggregationNode
There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There is 1 instance in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1779 +/- ##
=========================================
Coverage 73.64% 73.65%
Complexity 347 347
=========================================
Files 614 614
Lines 120131 120131
Branches 1015 1015
=========================================
+ Hits 88475 88484 +9
+ Misses 31447 31438 -9
Partials 209 209
Continue to review full report at Codecov.
|
Thanks for your contribution @SohamRatnaparkhi 👍 |
|
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
PR involves refractory changes. It refractors
PhysicalAggrerationNode
toPhysicalAggregationNode
at various instances in the codeWhat is the current behavior? (You can also link to an open issue here)
gh Fix typo of
PhysicalAggrerationNode
#1767What is the new behavior (if this is a feature change)?
In various instances as mentioned in
@zhanghaohit
comment,PhysicalAggrerationNode
has been replaced byPhysicalAggregationNode