Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix typo of PhysicalAggrerationNode #1779

Merged
merged 11 commits into from
May 10, 2022

Conversation

SohamRatnaparkhi
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    PR involves refractory changes. It refractors PhysicalAggrerationNode to PhysicalAggregationNode at various instances in the code

  • What is the current behavior? (You can also link to an open issue here)
    gh Fix typo of PhysicalAggrerationNode #1767

  • What is the new behavior (if this is a feature change)?
    In various instances as mentioned in @zhanghaohit comment, PhysicalAggrerationNode has been replaced by PhysicalAggregationNode

4paradigm#1770: In OpenMLDB/hybridse/src/passes/physical/split_aggregation_optimized.cc there are 7 instances where PhysicalAggrerationNode was replaced with PhysicalAggregationNode
4paradigm#1770: In OpenMLDB/hybridse/src/passes/physical/long_window_optimized.h , there was 1 instance in which PhysicalAggrerationNode was replaced to PhysicalAggregationNode
There were 9 instances in this file in which PhysicalAggrerationNode is replaced to PhysicalAggregationNode
There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 2 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There is 1 instance in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
4paradigm#1770: There are 3 instances in this file wherein, PhysicalAggrerationNode has been replaced with PhysicalAggregationNode
@github-actions github-actions bot added the execute-engine hybridse sql engine label May 10, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  73 files    73 suites   6m 1s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 18d788d.

@tobegit3hub tobegit3hub changed the title refractor: Fix typo of PhysicalAggrerationNode refractor: fix typo of PhysicalAggrerationNode May 10, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken changed the title refractor: fix typo of PhysicalAggrerationNode refactor: fix typo of PhysicalAggrerationNode May 10, 2022
@github-actions
Copy link
Contributor

HybridSE Linux Test Report

       67 files       235 suites   6m 5s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit 18d788d.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

       67 files       235 suites   6m 22s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit 18d788d.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       186 suites   1h 7m 28s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit 18d788d.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1779 (18d788d) into main (361f44d) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@            Coverage Diff            @@
##               main    #1779   +/-   ##
=========================================
  Coverage     73.64%   73.65%           
  Complexity      347      347           
=========================================
  Files           614      614           
  Lines        120131   120131           
  Branches       1015     1015           
=========================================
+ Hits          88475    88484    +9     
+ Misses        31447    31438    -9     
  Partials        209      209           
Impacted Files Coverage Δ
...ridse/src/passes/physical/batch_request_optimize.h 100.00% <ø> (ø)
...bridse/src/passes/physical/long_window_optimized.h 100.00% <ø> (ø)
.../src/passes/physical/split_aggregation_optimized.h 100.00% <ø> (ø)
...ridse/src/passes/physical/long_window_optimized.cc 76.39% <66.66%> (ø)
...idse/src/passes/physical/batch_request_optimize.cc 90.60% <71.42%> (ø)
...src/passes/physical/split_aggregation_optimized.cc 79.41% <83.33%> (ø)
hybridse/include/vm/physical_op.h 91.81% <100.00%> (ø)
hybridse/src/vm/physical_op.cc 81.32% <100.00%> (ø)
hybridse/src/vm/physical_op_test.cc 100.00% <100.00%> (ø)
hybridse/src/vm/runner.cc 67.87% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...18d788d. Read the comment docs.

@tobegit3hub tobegit3hub merged commit 57ccd7a into 4paradigm:main May 10, 2022
@tobegit3hub
Copy link
Collaborator

Thanks for your contribution @SohamRatnaparkhi 👍

@SohamRatnaparkhi
Copy link
Contributor Author

Thanks for your contribution @SohamRatnaparkhi 👍
Kudos!🤝👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants