Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused gflag variable (#1775) #1777

Merged
merged 1 commit into from
May 10, 2022
Merged

fix: remove unused gflag variable (#1775) #1777

merged 1 commit into from
May 10, 2022

Conversation

jmoldyvan
Copy link
Contributor

@jmoldyvan jmoldyvan commented May 9, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #1775 to remove instances of (enable_timeseries_table)

  • What is the current behavior? (You can also link to an open issue here)
    Just some code delete

  • What is the new behavior (if this is a feature change)?
    This doesn't actually change anything about the behavior

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 9, 2022
@jmoldyvan jmoldyvan changed the title Fix: Remove unused gflag variable (#1775) fix: remove unused gflag variable (#1775) May 9, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  73 files    73 suites   6m 18s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 6345192.

@lumianph lumianph requested a review from dl239 May 10, 2022 01:01
@github-actions
Copy link
Contributor

Linux Test Report

       57 files       186 suites   1h 6m 19s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit 6345192.

@lumianph lumianph requested a review from aceforeverd May 10, 2022 01:01
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1777 (6345192) into main (361f44d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1777      +/-   ##
============================================
- Coverage     73.64%   73.63%   -0.02%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120131   120131              
  Branches       1015     1015              
============================================
- Hits          88475    88461      -14     
- Misses        31447    31461      +14     
  Partials        209      209              
Impacted Files Coverage Δ
src/nameserver/name_server_impl.cc 42.15% <ø> (-0.16%) ⬇️
src/nameserver/name_server_test.cc 92.29% <ø> (ø)
src/nameserver/standalone_test.cc 100.00% <ø> (ø)
src/sdk/db_sdk.cc 61.67% <0.00%> (-1.37%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/client/ns_client.cc 44.62% <0.00%> (-0.15%) ⬇️
src/storage/mem_table.cc 89.13% <0.00%> (-0.14%) ⬇️
src/tablet/tablet_impl.cc 58.81% <0.00%> (-0.10%) ⬇️
src/client/tablet_client.cc 48.29% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...6345192. Read the comment docs.

@aceforeverd aceforeverd merged commit e0a1771 into 4paradigm:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused gflag variable
3 participants