Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kafka connector #1771

Merged
merged 2 commits into from
May 12, 2022

Conversation

vagetablechicken
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

SDK Test Report

  73 files    73 suites   7m 44s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 4a3fef9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Linux Test Report

       57 files       186 suites   1h 5m 54s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit 4a3fef9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1771 (4a3fef9) into main (361f44d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1771      +/-   ##
============================================
- Coverage     73.64%   73.64%   -0.01%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120131   120131              
  Branches       1015     1015              
============================================
- Hits          88475    88471       -4     
- Misses        31447    31451       +4     
  Partials        209      209              
Impacted Files Coverage Δ
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/tablet/tablet_impl.cc 58.81% <0.00%> (-0.10%) ⬇️
src/nameserver/name_server_impl.cc 42.23% <0.00%> (-0.07%) ⬇️
src/client/tablet_client.cc 48.29% <0.00%> (ø)
src/nameserver/standalone_test.cc 100.00% <0.00%> (ø)
src/nameserver/name_server_test.cc 92.29% <0.00%> (ø)
src/sdk/sql_cluster_router.cc 54.59% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...4a3fef9. Read the comment docs.

@vagetablechicken vagetablechicken marked this pull request as ready for review May 9, 2022 13:09
@@ -0,0 +1,114 @@
Confluent Community License Agreement
Copy link
Collaborator

@aceforeverd aceforeverd May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is license compatible ?

Copy link
Collaborator

@lumianph lumianph May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have checked with the legal team, it should be okay if we are not the competitor of their commercial products

extensions/kafka-connect-jdbc/pom.xml Outdated Show resolved Hide resolved
extensions/kafka-connect-jdbc/README.md Show resolved Hide resolved
extensions/kafka-connect-jdbc/licenses.html Show resolved Hide resolved
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants