Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue#1762 used constant instead of int in SimpleResultSet #1768

Merged
merged 1 commit into from
May 10, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented May 9, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    *code improvement

close #1762

@github-actions github-actions bot added the sdk openmldb java/python sdk label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

SDK Test Report

  73 files    73 suites   6m 27s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit b74d153.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Linux Test Report

       57 files       186 suites   1h 6m 26s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit b74d153.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1768 (b74d153) into main (361f44d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1768      +/-   ##
============================================
+ Coverage     73.64%   73.66%   +0.02%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120131   120131              
  Branches       1015     1015              
============================================
+ Hits          88475    88500      +25     
+ Misses        31447    31422      -25     
  Partials        209      209              
Impacted Files Coverage Δ
.../com/_4paradigm/openmldb/jdbc/SimpleResultSet.java 7.35% <0.00%> (ø)
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/storage/mem_table.cc 89.13% <0.00%> (-0.14%) ⬇️
src/nameserver/name_server_impl.cc 42.34% <0.00%> (+0.04%) ⬆️
src/sdk/sql_cluster_router.cc 54.41% <0.00%> (+0.13%) ⬆️
src/client/ns_client.cc 44.91% <0.00%> (+0.14%) ⬆️
src/tablet/tablet_impl.cc 59.13% <0.00%> (+0.22%) ⬆️
src/client/tablet_client.cc 48.60% <0.00%> (+0.31%) ⬆️
src/zk/dist_lock.cc 83.33% <0.00%> (+1.51%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...b74d153. Read the comment docs.

@tobegit3hub tobegit3hub changed the title Issue#1762 used constant instead of int in SimpleResultSet fix: issue#1762 used constant instead of int in SimpleResultSet May 10, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 9121617 into 4paradigm:main May 10, 2022
@tobegit3hub
Copy link
Collaborator

Thanks for your contribution @SaumyaBhushan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use constant instead of int in SimpleResultSet
4 participants