Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grafana dashboard): datasource.uid should point to ${datasource} #1754

Conversation

aceforeverd
Copy link
Collaborator

instead specific uid string, for non-existed uid, grafana ui will default points to ${datasource} menu, that's naughty.

@github-actions github-actions bot added the monitoring openmldb prometheus exporter & mixin label May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

SDK Test Report

  73 files    73 suites   6m 11s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 15045ef.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Linux Test Report

       57 files       186 suites   1h 7m 23s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit 15045ef.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1754 (15045ef) into main (c541226) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1754      +/-   ##
============================================
+ Coverage     73.66%   73.67%   +0.01%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120051   120051              
  Branches       1010     1010              
============================================
+ Hits          88437    88450      +13     
+ Misses        31405    31392      -13     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 53.95% <0.00%> (+0.30%) ⬆️
hybridse/include/base/spin_lock.h 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c541226...15045ef. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit ac438db into 4paradigm:main May 7, 2022
@aceforeverd aceforeverd deleted the fix/monitoring-dashboard-false-datasource branch May 7, 2022 05:51
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring openmldb prometheus exporter & mixin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants