fix(#1587): pure history rows range window iterator initialize position wrongly #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…truct previous code use `root_->SeekToFirst`, which result `root_` to the current row instead the first element inside window. That is different when the window is a pure history window
Codecov Report
@@ Coverage Diff @@
## main #1739 +/- ##
============================================
- Coverage 73.58% 73.55% -0.03%
Complexity 347 347
============================================
Files 613 613
Lines 119851 119851
Branches 1010 1010
============================================
- Hits 88187 88162 -25
- Misses 31455 31480 +25
Partials 209 209
Continue to review full report at Codecov.
|
vagetablechicken
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
InnerRangeList should call
SeekToFirston construct, close #1587previous code use
root_->SeekToFirst, which resultroot_to thecurrent row instead the first element inside window. That is different
when the window is a pure history window