Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ttl if new ttl greater than current ttl when depoly sql #1737

Merged
merged 13 commits into from
May 10, 2022

Conversation

keyu813
Copy link
Contributor

@keyu813 keyu813 commented Apr 29, 2022

close #1131

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

SDK Test Report

  74 files    74 suites   6m 26s ⏱️
175 tests 172 ✔️ 3 💤 0
216 runs  213 ✔️ 3 💤 0

Results for commit 1eb2313.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

Linux Test Report

       57 files       186 suites   1h 6m 9s ⏱️
  8 470 tests   8 462 ✔️ 8 💤 0
12 421 runs  12 413 ✔️ 8 💤 0

Results for commit 1eb2313.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1737 (1eb2313) into main (4c1dea2) will increase coverage by 0.14%.
The diff coverage is 87.76%.

@@             Coverage Diff              @@
##               main    #1737      +/-   ##
============================================
+ Coverage     73.56%   73.71%   +0.14%     
  Complexity      347      347              
============================================
  Files           613      614       +1     
  Lines        119853   120240     +387     
  Branches       1010     1015       +5     
============================================
+ Hits          88173    88638     +465     
+ Misses        31471    31393      -78     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.h 83.33% <ø> (ø)
src/sdk/sql_cluster_router.cc 54.97% <80.45%> (+1.25%) ⬆️
src/cmd/sql_cmd_test.cc 99.60% <100.00%> (+0.02%) ⬆️
...ridse/src/udf/default_defs/window_functions_def.cc 73.91% <0.00%> (-4.35%) ⬇️
hybridse/src/vm/schemas_context.cc 85.44% <0.00%> (-3.38%) ⬇️
...ridse/src/passes/physical/long_window_optimized.cc 76.39% <0.00%> (-2.80%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.61% <0.00%> (-0.95%) ⬇️
src/sdk/db_sdk.cc 61.67% <0.00%> (-0.91%) ⬇️
src/base/file_util.h 78.37% <0.00%> (-0.68%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1dea2...1eb2313. Read the comment docs.

src/cmd/sql_cmd_test.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_router.cc Show resolved Hide resolved
src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_router.cc Show resolved Hide resolved
src/cmd/sql_cmd_test.cc Outdated Show resolved Hide resolved
@dl239 dl239 merged commit d963b5a into 4paradigm:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Create table throw error when new ttl greater than current ttl
3 participants