Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update external function proto for offline #1733

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Apr 28, 2022

@tobegit3hub tobegit3hub added this to the v0.5 milestone Apr 28, 2022
@tobegit3hub tobegit3hub requested a review from dl239 April 28, 2022 07:54
@tobegit3hub tobegit3hub self-assigned this Apr 28, 2022
@github-actions github-actions bot added batch-engine openmldb batch(offline) engine storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager labels Apr 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

SDK Test Report

  73 files    73 suites   5m 47s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit e89a1e6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Linux Test Report

       57 files       186 suites   1h 10m 58s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit e89a1e6.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1733 (e89a1e6) into main (c541226) will decrease coverage by 0.01%.
The diff coverage is 5.26%.

@@             Coverage Diff              @@
##               main    #1733      +/-   ##
============================================
- Coverage     73.66%   73.65%   -0.02%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120051   120083      +32     
  Branches       1010     1015       +5     
============================================
+ Hits          88437    88447      +10     
- Misses        31405    31427      +22     
  Partials        209      209              
Impacted Files Coverage Δ
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.61% <0.00%> (-0.95%) ⬇️
...openmldb/taskmanager/client/TaskManagerClient.java 0.00% <ø> (ø)
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/udf/ExternalFunctionManager.java 0.00% <0.00%> (ø)
...m/openmldb/taskmanager/spark/SparkJobManager.scala 0.00% <ø> (ø)
src/client/taskmanager_client.cc 0.00% <0.00%> (ø)
src/client/taskmanager_client.h 0.00% <ø> (ø)
src/sdk/db_sdk.cc 62.13% <0.00%> (+0.45%) ⬆️
src/sdk/sql_cluster_router.cc 53.64% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c541226...e89a1e6. Read the comment docs.

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

HybridSE Linux Test Report

       67 files       235 suites   5m 58s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit e89a1e6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 47s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit e89a1e6.

♻️ This comment has been updated with latest results.

@vagetablechicken vagetablechicken merged commit 9479495 into 4paradigm:main May 6, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output data is null when using external UDF in offline
4 participants