Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jdbc improvements for kafka #1729

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

vagetablechicken
Copy link
Collaborator

kafka needs more jdbc support

@github-actions github-actions bot added sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet labels Apr 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

SDK Test Report

  73 files    73 suites   7m 51s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 351e542.

♻️ This comment has been updated with latest results.

@vagetablechicken vagetablechicken self-assigned this Apr 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

Linux Test Report

       56 files       185 suites   1h 7m 51s ⏱️
  8 390 tests   8 382 ✔️ 8 💤 0
12 306 runs  12 298 ✔️ 8 💤 0

Results for commit 351e542.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1729 (351e542) into main (1afcf58) will increase coverage by 5.64%.
The diff coverage is 50.50%.

@@             Coverage Diff              @@
##               main    #1729      +/-   ##
============================================
+ Coverage     67.82%   73.46%   +5.64%     
- Complexity      323      347      +24     
============================================
  Files           609      612       +3     
  Lines        118679   119481     +802     
  Branches       1000     1001       +1     
============================================
+ Hits          80491    87780    +7289     
+ Misses        37981    31492    -6489     
- Partials        207      209       +2     
Impacted Files Coverage Δ
...om/_4paradigm/openmldb/jdbc/PreparedStatement.java 21.45% <ø> (ø)
.../main/java/com/_4paradigm/openmldb/sdk/Schema.java 66.66% <ø> (-4.77%) ⬇️
...openmldb/sdk/impl/InsertPreparedStatementImpl.java 41.11% <0.00%> (-1.79%) ⬇️
...aradigm/openmldb/jdbc/SimpleResultSetMetaData.java 15.38% <15.38%> (ø)
.../com/_4paradigm/openmldb/jdbc/SimpleResultSet.java 7.35% <76.92%> (+3.27%) ⬆️
...com/_4paradigm/openmldb/jdbc/DatabaseMetaData.java 29.60% <80.95%> (+8.91%) ⬆️
...va/com/_4paradigm/openmldb/jdbc/SQLConnection.java 39.47% <100.00%> (+2.63%) ⬆️
src/sdk/sql_cluster_router.cc 54.36% <100.00%> (+0.42%) ⬆️
src/storage/aggregator.cc 74.57% <0.00%> (-10.60%) ⬇️
...penmldb/batch/catalog/OpenmldbCatalogService.scala 58.06% <0.00%> (-6.65%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fa68d...351e542. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit 16b8f2e into 4paradigm:main Apr 28, 2022
@vagetablechicken vagetablechicken deleted the kafka branch April 28, 2022 08:20
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants