Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query result is incorrect after adding a new index in standalone version #1721

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

keyu813
Copy link
Contributor

@keyu813 keyu813 commented Apr 26, 2022

close #708

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Apr 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

SDK Test Report

  73 files    73 suites   6m 50s ⏱️
173 tests 170 ✔️ 3 💤 0
213 runs  210 ✔️ 3 💤 0

Results for commit ce53cb5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Linux Test Report

       56 files       185 suites   1h 13m 4s ⏱️
  8 388 tests   8 380 ✔️ 8 💤 0
12 304 runs  12 296 ✔️ 8 💤 0

Results for commit ce53cb5.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1721 (ce53cb5) into main (1ac480d) will increase coverage by 5.62%.
The diff coverage is 87.93%.

@@             Coverage Diff              @@
##               main    #1721      +/-   ##
============================================
+ Coverage     67.84%   73.47%   +5.62%     
- Complexity      323      325       +2     
============================================
  Files           609      611       +2     
  Lines        118660   119391     +731     
  Branches       1000      992       -8     
============================================
+ Hits          80505    87719    +7214     
+ Misses        37948    31465    -6483     
  Partials        207      207              
Impacted Files Coverage Δ
src/nameserver/name_server_impl.cc 42.31% <0.00%> (+2.75%) ⬆️
src/catalog/tablet_catalog_test.cc 96.14% <100.00%> (+0.08%) ⬆️
src/cmd/sql_cmd_test.cc 99.56% <100.00%> (+0.01%) ⬆️
src/sdk/sql_cluster_router.cc 54.33% <100.00%> (+0.36%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/storage/aggregator.cc 74.57% <0.00%> (-10.60%) ⬇️
...penmldb/batch/catalog/OpenmldbCatalogService.scala 58.06% <0.00%> (-6.65%) ⬇️
..._4paradigm/openmldb/batch/utils/DataTypeUtil.scala 30.69% <0.00%> (-4.54%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291dd9d...ce53cb5. Read the comment docs.

@dl239 dl239 merged commit 972ceab into 4paradigm:main Apr 27, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After adding a new index to the stand-alone version, the query result is incorrect
3 participants