Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine error handling for SHOW COMPONENTS #1704

Merged

Conversation

aceforeverd
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@aceforeverd aceforeverd added this to the v0.5 milestone Apr 24, 2022
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Apr 24, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  73 files    73 suites   6m 3s ⏱️
173 tests 170 ✔️ 3 💤 0
213 runs  210 ✔️ 3 💤 0

Results for commit bdfb95c.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd
Copy link
Collaborator Author

Online Monitoring

@github-actions
Copy link
Contributor

Linux Test Report

       56 files       185 suites   1h 20m 17s ⏱️
  8 384 tests   8 376 ✔️ 8 💤 0
12 300 runs  12 292 ✔️ 8 💤 0

Results for commit bdfb95c.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1704 (bdfb95c) into main (1afcf58) will decrease coverage by 0.01%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##               main    #1704      +/-   ##
============================================
- Coverage     67.82%   67.80%   -0.02%     
  Complexity      323      323              
============================================
  Files           609      609              
  Lines        118679   118685       +6     
  Branches       1000     1000              
============================================
- Hits          80491    80475      -16     
- Misses        37981    38003      +22     
  Partials        207      207              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 53.84% <69.23%> (-0.10%) ⬇️
src/catalog/tablet_catalog.cc 69.76% <0.00%> (-0.90%) ⬇️
src/tablet/tablet_impl.cc 43.19% <0.00%> (-0.38%) ⬇️
src/replica/log_replicator.cc 79.47% <0.00%> (-0.33%) ⬇️
src/nameserver/name_server_impl.cc 39.40% <0.00%> (-0.05%) ⬇️
src/zk/zk_client.cc 84.33% <0.00%> (+0.26%) ⬆️
hybridse/src/plan/planner.cc 93.50% <0.00%> (+0.30%) ⬆️
src/sdk/db_sdk.cc 65.44% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309144e...bdfb95c. Read the comment docs.

@aceforeverd aceforeverd merged commit 2f7e29b into 4paradigm:main Apr 25, 2022
@aceforeverd aceforeverd deleted the fix/show-components-error-handling branch April 25, 2022 07:19
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants