Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support register external function for offline #1700

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Apr 22, 2022

TODO:

  • Remove if_exists in DropFunctionRequest in taskmanager.proto
  • Normalize the file and offline_file in ExternalFun in common.proto

@tobegit3hub tobegit3hub self-assigned this Apr 22, 2022
@github-actions github-actions bot added batch-engine openmldb batch(offline) engine task-manager openmldb taskmanager labels Apr 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

SDK Test Report

  73 files    73 suites   6m 28s ⏱️
173 tests 170 ✔️ 3 💤 0
213 runs  210 ✔️ 3 💤 0

Results for commit 5a5770a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

Linux Test Report

       56 files       185 suites   1h 7m 18s ⏱️
  8 384 tests   8 376 ✔️ 8 💤 0
12 300 runs  12 292 ✔️ 8 💤 0

Results for commit 5a5770a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1700 (5a5770a) into main (1ac480d) will decrease coverage by 0.00%.
The diff coverage is 45.63%.

@@             Coverage Diff              @@
##               main    #1700      +/-   ##
============================================
- Coverage     67.84%   67.83%   -0.01%     
- Complexity      323      325       +2     
============================================
  Files           609      610       +1     
  Lines        118660   118743      +83     
  Branches       1000      983      -17     
============================================
+ Hits          80505    80555      +50     
- Misses        37948    37981      +33     
  Partials        207      207              
Impacted Files Coverage Δ
..._4paradigm/openmldb/batch/utils/DataTypeUtil.scala 30.69% <0.00%> (-4.54%) ⬇️
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/udf/ExternalFunctionManager.java 0.00% <0.00%> (ø)
...m/openmldb/taskmanager/spark/SparkJobManager.scala 0.00% <0.00%> (ø)
...penmldb/batch/catalog/OpenmldbCatalogService.scala 58.06% <50.00%> (-6.65%) ⬇️
...in/java/com/_4paradigm/hybridse/sdk/SqlEngine.java 61.66% <60.00%> (-1.80%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 62.75% <63.63%> (-0.94%) ⬇️
src/catalog/tablet_catalog_test.cc 96.14% <100.00%> (+0.08%) ⬆️
src/sdk/sql_cluster_router.cc 53.98% <100.00%> (+0.01%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291dd9d...5a5770a. Read the comment docs.

@tobegit3hub tobegit3hub merged commit 1382656 into 4paradigm:main Apr 26, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support register external function for offline
3 participants