-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support register external function for offline #1700
Merged
tobegit3hub
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/support_load_external_function_for_offline
Apr 26, 2022
Merged
feat: support register external function for offline #1700
tobegit3hub
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/support_load_external_function_for_offline
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
batch-engine
openmldb batch(offline) engine
task-manager
openmldb taskmanager
labels
Apr 22, 2022
dl239
reviewed
Apr 24, 2022
java/openmldb-batch/src/main/scala/com/_4paradigm/openmldb/batch/SparkPlanner.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
============================================
- Coverage 67.84% 67.83% -0.01%
- Complexity 323 325 +2
============================================
Files 609 610 +1
Lines 118660 118743 +83
Branches 1000 983 -17
============================================
+ Hits 80505 80555 +50
- Misses 37948 37981 +33
Partials 207 207
Continue to review full report at Codecov.
|
dl239
approved these changes
Apr 25, 2022
aceforeverd
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
if_exists
in DropFunctionRequest in taskmanager.protofile
andoffline_file
in ExternalFun in common.proto