Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix message when icu package not found #1651

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix: fix message when icu package not found #1651

merged 1 commit into from
Apr 19, 2022

Conversation

ikamii
Copy link
Contributor

@ikamii ikamii commented Apr 18, 2022

Fixed the message when icu package not found.

Issue: #1648

Solution:

solution

@github-actions
Copy link
Contributor

SDK Test Report

  72 files    72 suites   6m 2s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit eb6a26b.

@dl239 dl239 changed the title fixed message when icu package not found fix: message when icu package not found Apr 19, 2022
@dl239 dl239 changed the title fix: message when icu package not found fix: fix message when icu package not found Apr 19, 2022
@zhanghaohit zhanghaohit self-requested a review April 19, 2022 01:15
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Linux Test Report

     54 files       98 suites   36m 30s ⏱️
4 318 tests 4 317 ✔️ 0 💤 1

For more details on these failures, see this check.

Results for commit eb6a26b.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1651 (eb6a26b) into main (c139d6d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1651   +/-   ##
=========================================
  Coverage     67.42%   67.43%           
  Complexity      323      323           
=========================================
  Files           607      607           
  Lines        115890   115890           
  Branches       1000     1000           
=========================================
+ Hits          78141    78150    +9     
+ Misses        37542    37533    -9     
  Partials        207      207           
Impacted Files Coverage Δ
src/sdk/db_sdk.cc 64.53% <0.00%> (-0.99%) ⬇️
src/zk/zk_client.cc 84.08% <0.00%> (-0.80%) ⬇️
src/replica/log_replicator.cc 79.47% <0.00%> (-0.33%) ⬇️
hybridse/src/plan/planner.cc 93.20% <0.00%> (-0.31%) ⬇️
src/tablet/tablet_impl.cc 44.01% <0.00%> (-0.23%) ⬇️
hybridse/src/vm/schemas_context.cc 88.62% <0.00%> (-0.22%) ⬇️
hybridse/src/node/plan_node.cc 85.19% <0.00%> (-0.18%) ⬇️
hybridse/src/vm/transform.cc 84.58% <0.00%> (-0.16%) ⬇️
src/sdk/sql_cluster_router.cc 52.85% <0.00%> (+0.08%) ⬆️
src/nameserver/name_server_impl.cc 39.28% <0.00%> (+0.16%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc54ff...eb6a26b. Read the comment docs.

@aceforeverd aceforeverd merged commit 4379672 into 4paradigm:main Apr 19, 2022
@ikamii ikamii deleted the kutlay branch April 19, 2022 06:25
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants