Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unsaferow for window append slice #1637

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the bug Something isn't working label Apr 15, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Apr 15, 2022
@tobegit3hub tobegit3hub self-assigned this Apr 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

SDK Test Report

  73 files    73 suites   5m 50s ⏱️
173 tests 170 ✔️ 3 💤 0
213 runs  210 ✔️ 3 💤 0

Results for commit 43c5b66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

Linux Test Report

       56 files       185 suites   1h 6m 24s ⏱️
  8 379 tests   8 371 ✔️ 8 💤 0
12 295 runs  12 287 ✔️ 8 💤 0

Results for commit 43c5b66.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1637 (43c5b66) into main (6c431fb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1637      +/-   ##
============================================
- Coverage     67.73%   67.73%   -0.01%     
  Complexity      323      323              
============================================
  Files           608      608              
  Lines        118405   118405              
  Branches       1000     1000              
============================================
- Hits          80203    80199       -4     
- Misses        37995    37999       +4     
  Partials        207      207              
Impacted Files Coverage Δ
.../com/_4paradigm/openmldb/batch/SparkRowCodec.scala 66.86% <100.00%> (+10.46%) ⬆️
src/zk/zk_client.cc 83.55% <0.00%> (-0.79%) ⬇️
src/replica/log_replicator.cc 78.82% <0.00%> (-0.66%) ⬇️
hybridse/src/plan/planner.cc 93.20% <0.00%> (-0.61%) ⬇️
hybridse/src/vm/transform.cc 84.42% <0.00%> (-0.32%) ⬇️
src/tablet/tablet_impl.cc 43.36% <0.00%> (-0.30%) ⬇️
hybridse/src/vm/schemas_context.cc 88.81% <0.00%> (-0.22%) ⬇️
hybridse/src/planv2/ast_node_converter.cc 94.33% <0.00%> (-0.15%) ⬇️
src/sdk/sql_cluster_router.cc 52.83% <0.00%> (-0.05%) ⬇️
src/nameserver/name_server_impl.cc 39.51% <0.00%> (-0.02%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c431fb...43c5b66. Read the comment docs.

@tobegit3hub tobegit3hub merged commit 1848785 into 4paradigm:main Apr 20, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get unexpected long overflow for offline job when enabling UnsafeRowOpt
3 participants