feat: add avg, count, min and max ops in runner
#1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanghaohit
force-pushed
the
feat/more-aggregator-op
branch
from
ecb2dad to
b3f6280
Compare
Codecov Report
@@ Coverage Diff @@
## main #1627 +/- ##
============================================
+ Coverage 67.42% 67.76% +0.33%
Complexity 323 323
============================================
Files 607 608 +1
Lines 115890 116954 +1064
Branches 1000 1000
============================================
+ Hits 78141 79250 +1109
+ Misses 37542 37497 -45
Partials 207 207
Continue to review full report at Codecov.
|
dl239
reviewed
Apr 19, 2022
| @@ -231,7 +231,9 @@ bool LongWindowOptimized::OptimizeWithPreAggr(vm::PhysicalAggrerationNode* in, i | |||
| LOG(ERROR) << "Fail to create PhysicalReduceAggregationNode: " << status; | |||
| return false; | |||
| } | |||
| LOG(INFO) << "[LongWindowOptimized] Before transform sql:\n" << (*output)->GetTreeString(); | |||
There was a problem hiding this comment.
Forgot to discuss this in the PR review.
For testing and verification, we need some log information to see whether we are really using long_window optimization or not.
Since the log will only print during deploy, it is kind of acceptable. What do you think?
If it is too annoying, can change to Debug log.
There was a problem hiding this comment.
if only in deploy, it's no matter
dl239
approved these changes
Apr 19, 2022
aceforeverd
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1244
close #1245
close #1246
close #1247