-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(monitoring): openmldb prometheus exporter for v0.5.0 #1584
feat(monitoring): openmldb prometheus exporter for v0.5.0 #1584
Conversation
since it rely on latest code, openmldb dep is set as path dependency
collect table status, component status & deploy query response time metrics
previously it is microsecond implicitly, which may inconvenient for end user. However, the time data trasnfrom internally (which is the GetAndFlushDeployStats RPC in tablet) keeps microsecond
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
============================================
- Coverage 67.26% 67.21% -0.05%
Complexity 323 323
============================================
Files 600 600
Lines 113967 113983 +16
Branches 998 998
============================================
- Hits 76655 76615 -40
- Misses 37105 37161 +56
Partials 207 207
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will not provide monitoring py in binary release, instead, it will publish to pypi later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the PR adopted newly defined monitoring metrics in Online Monitoring RFC into our python-based prometheus exporter. Which is:
other metrics in the exporter will deleted since they will pull directly by prometheus server ( BRPC exported natively, we do not need export it again). The only left metric is the application memory
The PR will
SHOW STMT
in python sdk, close feat(python sdk): support SHOW statements #1270What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?