Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): openmldb prometheus exporter for v0.5.0 #1584

Merged
merged 12 commits into from
Apr 8, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Apr 6, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

the PR adopted newly defined monitoring metrics in Online Monitoring RFC into our python-based prometheus exporter. Which is:

  • table status
  • component status
  • deploy response time

other metrics in the exporter will deleted since they will pull directly by prometheus server ( BRPC exported natively, we do not need export it again). The only left metric is the application memory

The PR will

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

since it rely on latest code, openmldb dep is set as path dependency
collect table status, component status & deploy query response time
metrics
previously it is microsecond implicitly, which may inconvenient for end
user. However, the time data trasnfrom internally (which is the
GetAndFlushDeployStats RPC in tablet) keeps microsecond
@aceforeverd aceforeverd added the enhancement New feature or request label Apr 6, 2022
@aceforeverd aceforeverd added this to the v0.5 milestone Apr 6, 2022
@aceforeverd aceforeverd self-assigned this Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

SDK Test Report

  72 files    72 suites   6m 0s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit 9ec3cc7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Linux Test Report

       55 files       182 suites   46m 50s ⏱️
  8 198 tests   8 198 ✔️ 0 💤 0
12 114 runs  12 114 ✔️ 0 💤 0

Results for commit 9ec3cc7.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1584 (9ec3cc7) into main (70742d1) will decrease coverage by 0.04%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##               main    #1584      +/-   ##
============================================
- Coverage     67.26%   67.21%   -0.05%     
  Complexity      323      323              
============================================
  Files           600      600              
  Lines        113967   113983      +16     
  Branches        998      998              
============================================
- Hits          76655    76615      -40     
- Misses        37105    37161      +56     
  Partials        207      207              
Impacted Files Coverage Δ
src/nameserver/system_table.h 96.66% <ø> (ø)
...atistics/query_response_time/query_response_time.h 82.60% <75.00%> (-10.94%) ⬇️
src/nameserver/name_server_impl.cc 38.83% <100.00%> (-0.26%) ⬇️
src/tablet/tablet_impl.cc 42.34% <100.00%> (-0.33%) ⬇️
src/rpc/rpc_client.h 60.81% <0.00%> (-4.06%) ⬇️
hybridse/src/vm/sql_compiler.cc 80.34% <0.00%> (-0.88%) ⬇️
src/client/tablet_client.cc 40.42% <0.00%> (-0.32%) ⬇️
src/sdk/sql_cluster_router.cc 52.59% <0.00%> (-0.32%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70742d1...9ec3cc7. Read the comment docs.

monitoring/pyproject.toml Show resolved Hide resolved
monitoring/pyproject.toml Show resolved Hide resolved
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

will not provide monitoring py in binary release, instead, it will
publish to pypi later
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 912f022 into 4paradigm:main Apr 8, 2022
@aceforeverd aceforeverd deleted the feat/openmldb-exporter branch April 8, 2022 02:43
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(python sdk): support SHOW statements
4 participants