Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more aggregator op #1583

Merged
merged 8 commits into from
Apr 12, 2022
Merged

Conversation

nautaa
Copy link
Collaborator

@nautaa nautaa commented Apr 6, 2022

@nautaa nautaa self-assigned this Apr 6, 2022
@nautaa nautaa added the enhancement New feature or request label Apr 6, 2022
@zhanghaohit
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

SDK Test Report

  72 files    72 suites   5m 46s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit 72f8934.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Linux Test Report

       55 files       182 suites   44m 43s ⏱️
  8 206 tests   8 206 ✔️ 0 💤 0
12 122 runs  12 122 ✔️ 0 💤 0

Results for commit 72f8934.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1583 (72f8934) into main (1e06650) will increase coverage by 0.11%.
The diff coverage is 92.59%.

@@             Coverage Diff              @@
##               main    #1583      +/-   ##
============================================
+ Coverage     67.21%   67.33%   +0.11%     
  Complexity      323      323              
============================================
  Files           600      600              
  Lines        114047   114605     +558     
  Branches        995      995              
============================================
+ Hits          76657    77165     +508     
- Misses        37183    37233      +50     
  Partials        207      207              
Impacted Files Coverage Δ
src/codec/codec.h 100.00% <ø> (ø)
src/base/strings.h 55.10% <55.55%> (+0.04%) ⬆️
src/codec/codec.cc 69.18% <85.27%> (+2.28%) ⬆️
src/storage/aggregator.cc 84.53% <91.09%> (+5.62%) ⬆️
src/storage/aggregator_test.cc 97.72% <96.55%> (+0.16%) ⬆️
src/codec/codec_test.cc 100.00% <100.00%> (ø)
src/storage/aggregator.h 95.23% <100.00%> (+11.90%) ⬆️
src/rpc/rpc_client.h 64.86% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 63.66% <0.00%> (-1.21%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e06650...72f8934. Read the comment docs.

@zhanghaohit zhanghaohit self-requested a review April 8, 2022 02:23
src/codec/codec.cc Show resolved Hide resolved
src/storage/aggregator.cc Outdated Show resolved Hide resolved
src/storage/aggregator.h Outdated Show resolved Hide resolved
src/storage/aggregator_test.cc Outdated Show resolved Hide resolved
src/storage/aggregator_test.cc Show resolved Hide resolved
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanghaohit zhanghaohit merged commit aeeb4cb into 4paradigm:main Apr 12, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants