feat: add external c++ udf #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1509 +/- ##
============================================
- Coverage 67.47% 67.11% -0.36%
Complexity 323 323
============================================
Files 600 600
Lines 114806 114632 -174
Branches 999 998 -1
============================================
- Hits 77462 76939 -523
- Misses 37137 37486 +349
Partials 207 207
Continue to review full report at Codecov.
|
zhanghaohit
reviewed
Apr 7, 2022
Closed
aceforeverd
reviewed
Apr 13, 2022
src/cmd/sql_cmd_test.cc
Outdated
| sr->ExecuteSQL(create_sql, &status); | ||
| ASSERT_TRUE(status.IsOK()) << status.msg; | ||
| HandleSQL("insert into t1 values ('aab', 11, 1.2);"); | ||
| std::string so_path = openmldb::test::GetParentDir(openmldb::test::GetExeDir()) + "/libtest_udf.so"; |
There was a problem hiding this comment.
should ensure libtest_udf.so was built before sql_cmd_test
There was a problem hiding this comment.
libtest_udf.so has been built before sql_cmd_test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create function statement as below:
drop function statement:
execute udf function
TODO:
Problems: