Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize join condition expr #1502

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Mar 23, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Mar 23, 2022
@tobegit3hub tobegit3hub self-assigned this Mar 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

SDK Test Report

  70 files    70 suites   7m 3s ⏱️
158 tests 155 ✔️ 3 💤 0
197 runs  194 ✔️ 3 💤 0

Results for commit a415b92.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

Linux Test Report

       52 files       179 suites   40m 0s ⏱️
  8 173 tests   8 173 ✔️ 0 💤 0
12 089 runs  12 089 ✔️ 0 💤 0

Results for commit a415b92.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

HybridSE Linux Test Report

       65 files       231 suites   6m 3s ⏱️
18 868 tests 18 868 ✔️ 0 💤 0

Results for commit a415b92.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

HybridSE Mac Test Report

       65 files       231 suites   7m 0s ⏱️
18 868 tests 18 868 ✔️ 0 💤 0

Results for commit a415b92.

♻️ This comment has been updated with latest results.

@tobegit3hub
Copy link
Collaborator Author

tobegit3hub commented Mar 23, 2022

openmldb.opt.join.spark_expr is enabled by default.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1502 (a415b92) into main (90147ca) will decrease coverage by 0.02%.
The diff coverage is 47.54%.

@@             Coverage Diff              @@
##               main    #1502      +/-   ##
============================================
- Coverage     66.54%   66.52%   -0.03%     
  Complexity      281      281              
============================================
  Files           579      580       +1     
  Lines        110290   110373      +83     
  Branches        941      968      +27     
============================================
+ Hits          73395    73428      +33     
- Misses        36703    36753      +50     
  Partials        192      192              
Impacted Files Coverage Δ
hybridse/include/node/sql_node.h 79.62% <ø> (ø)
...radigm/openmldb/batch/nodes/ConstProjectPlan.scala 1.51% <0.00%> (-3.22%) ⬇️
...com/_4paradigm/openmldb/batch/nodes/JoinPlan.scala 51.16% <23.07%> (-23.64%) ⬇️
...paradigm/openmldb/batch/utils/ExpressionUtil.scala 53.76% <53.76%> (ø)
...4paradigm/openmldb/batch/OpenmldbBatchConfig.scala 86.66% <100.00%> (ø)
...adigm/openmldb/batch/nodes/SimpleProjectPlan.scala 65.38% <100.00%> (ø)
src/tablet/tablet_impl.cc 38.81% <0.00%> (+0.02%) ⬆️
src/nameserver/name_server_impl.cc 37.70% <0.00%> (+0.04%) ⬆️
src/sdk/db_sdk.cc 64.67% <0.00%> (+0.59%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90147ca...a415b92. Read the comment docs.

@tobegit3hub tobegit3hub enabled auto-merge (squash) March 24, 2022 04:01
@tobegit3hub tobegit3hub merged commit 6e5b5d2 into 4paradigm:main Mar 24, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join condition use encoder/decoder which is inefficient for rows with many columns
3 participants