Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support taskmanager sync rpc #1486

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Mar 21, 2022

Closes #1436, closes #1137

usage:

set @@sync_job=true;
# if rpc timeout, set it bigger
set @@job_timeout='100000';

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2022

Linux Test Report

       52 files       179 suites   39m 45s ⏱️
  8 173 tests   8 173 ✔️ 0 💤 0
12 089 runs  12 089 ✔️ 0 💤 0

Results for commit a311755.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

SDK Test Report

  70 files    70 suites   5m 46s ⏱️
157 tests 154 ✔️ 3 💤 0
196 runs  193 ✔️ 3 💤 0

Results for commit a311755.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #1486 (a311755) into main (6b926bb) will decrease coverage by 0.01%.
The diff coverage is 11.26%.

@@             Coverage Diff              @@
##               main    #1486      +/-   ##
============================================
- Coverage     66.59%   66.57%   -0.02%     
  Complexity      281      281              
============================================
  Files           577      577              
  Lines        110191   110240      +49     
  Branches        932      937       +5     
============================================
+ Hits          73378    73392      +14     
- Misses        36621    36656      +35     
  Partials        192      192              
Impacted Files Coverage Δ
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
src/client/taskmanager_client.cc 0.00% <0.00%> (ø)
src/client/taskmanager_client.h 0.00% <0.00%> (ø)
src/sdk/sql_cluster_router.h 66.66% <ø> (ø)
src/sdk/sql_router.h 33.33% <ø> (ø)
src/sdk/sql_cluster_router.cc 44.10% <30.76%> (+0.32%) ⬆️
src/zk/zk_client.cc 83.28% <0.00%> (-0.27%) ⬇️
src/tablet/tablet_impl.cc 38.69% <0.00%> (-0.09%) ⬇️
src/nameserver/name_server_impl.cc 37.67% <0.00%> (+0.02%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b926bb...a311755. Read the comment docs.

@dl239
Copy link
Collaborator

dl239 commented Mar 22, 2022

PR review meeting note:

  • update the sleep strategy later
  • check new added variable in nameserver @keyu813

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 90147ca into 4paradigm:main Mar 22, 2022
@lumianph
Copy link
Collaborator

@dl239 dl239 mentioned this pull request Mar 29, 2022
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 30, 2022
@lumianph lumianph mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sync rpc impl in taskmanager Add blocking api for TaskManager APIs
4 participants