feat: add standalone mode in java sdk #1485

keyu813 · 2022-03-21T03:20:03Z

close #620
onebox/start_onebox.sh support standalone mode
close #1523

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java

github-actions · 2022-03-21T04:37:32Z

SDK Test Report

  70 files   70 suites 5m 56s ⏱️
171 tests 168 ✔️ 3 💤 0 ❌
210 runs 207 ✔️ 3 💤 0 ❌

Results for commit 89ea7ea.

♻️ This comment has been updated with latest results.

github-actions · 2022-03-21T05:00:39Z

Linux Test Report

      52 files     179 suites 40m 22s ⏱️
  8 173 tests   8 173 ✔️ 0 💤 0 ❌
12 089 runs 12 089 ✔️ 0 💤 0 ❌

Results for commit 89ea7ea.

♻️ This comment has been updated with latest results.

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/SdkOption.java

dl239 · 2022-03-21T07:45:36Z

add standalone test. start standalone openmldb in onebox/start_onebox.sh

keyu813 · 2022-03-21T08:02:20Z

add standalone test. start standalone openmldb in onebox/start_onebox.sh

ok, should I add a StandaloneSmokeTest in /test ? or just update SQLRouterSmokeTest.java ?

codecov · 2022-03-21T09:09:19Z

Codecov Report

Merging #1485 (89ea7ea) into main (75f3c1b) will increase coverage by 0.10%.
The diff coverage is 95.65%.

@@             Coverage Diff              @@
##               main    #1485      +/-   ##
============================================
+ Coverage     66.51%   66.62%   +0.10%     
  Complexity      281      281              
============================================
  Files           583      587       +4     
  Lines        110438   111006     +568     
  Branches        974      981       +7     
============================================
+ Hits          73455    73953     +498     
- Misses        36791    36861      +70     
  Partials        192      192

Impacted Files	Coverage Δ
...in/java/com/_4paradigm/openmldb/sdk/SdkOption.java	`88.88% <75.00%> (+9.94%)`	⬆️
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java	`52.85% <100.00%> (+2.35%)`	⬆️
src/nameserver/name_server_impl.cc	`37.98% <100.00%> (ø)`
...paradigm/openmldb/batch/utils/ExpressionUtil.scala	`45.13% <0.00%> (-8.64%)`	⬇️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala	`60.40% <0.00%> (-5.04%)`	⬇️
hybridse/include/base/fe_status.h	`92.30% <0.00%> (-3.70%)`	⬇️
...ybridse/examples/toydb/src/tablet/tablet_catalog.h	`63.15% <0.00%> (-3.51%)`	⬇️
src/zk/dist_lock.cc	`81.81% <0.00%> (-1.52%)`	⬇️
src/catalog/tablet_catalog.cc	`68.56% <0.00%> (-0.90%)`	⬇️
src/catalog/base.cc	`100.00% <0.00%> (ø)`
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f3c1b...89ea7ea. Read the comment docs.

java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/StandaloneRouterSmokeTest.java

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java

java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/TestConfig.java

onebox/start_onebox.sh

aceforeverd · 2022-03-30T03:17:48Z

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java

+            sqlOpt.setEnable_debug(option.getEnableDebug());
+            sqlOpt.setRequest_timeout(option.getRequestTimeout());
+            this.sqlRouter = sql_router_sdk.NewClusterSQLRouter(sqlOpt);
+            sqlOpt.delete();


don't the GC handle it automatically ? @vagetablechicken

If swigCMemOwn==true, it'll gc. But we've found CMem cost too much or memory leak before(maybe gc is not immediate), so in java sdk, we manually delete CMem in every place.
Just leave it, until we can remove all manul deletion.

.github/workflows/sdk.yml

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/SdkOption.java

aceforeverd · 2022-03-30T03:31:05Z

java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/SQLRouterSmokeTest.java


    static {
        try {
            SdkOption option = new SdkOption();
            option.setZkPath(TestConfig.ZK_PATH);
            option.setZkCluster(TestConfig.ZK_CLUSTER);
            option.setSessionTimeout(200000);
-            router = new SqlClusterExecutor(option);
-            java.sql.Statement state = router.getStatement();
+            clusterRouter = new SqlClusterExecutor(option);


must call Init() for both clusterRouter and standaloneRouter before use

must call Init() for both clusterRouter and standaloneRouter before use

which init()? SqlClusterExecutor seems have no Init() method

router->Init() is in SqlClusterExecutor. It's better to change the name. clusterRouter -> clusterExecutor or clusterClient

aceforeverd · 2022-03-30T03:32:12Z

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/SdkOption.java

+        return isClusterMode;
+    }
+
+    public void setClusterMode(boolean clusterMode) {


where the option is set ?

where the option is set ?

before use SqlClusterExecutor we should set option, see SQLRouterSmokeTest

add standalone mode in javasdk

6e09cc8

dl239 reviewed Mar 21, 2022

View reviewed changes

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java Outdated Show resolved Hide resolved

update code

5c0ff7f

dl239 reviewed Mar 21, 2022

View reviewed changes

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/SdkOption.java Outdated Show resolved Hide resolved

update code

987c9cd

“keyu813” added 3 commits March 21, 2022 19:16

onebox support standalone and add jave sdk test in standalone

4aa052e

update stop.sh

2b743b1

update stop_all.sh

9744ad0

tobegit3hub assigned keyu813 Mar 23, 2022

update

ef321d3

dl239 reviewed Mar 28, 2022

View reviewed changes

java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/StandaloneRouterSmokeTest.java Outdated Show resolved Hide resolved

dl239 reviewed Mar 28, 2022

View reviewed changes

java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/StandaloneRouterSmokeTest.java Outdated Show resolved Hide resolved

“keyu813” added 3 commits March 28, 2022 13:20

update

151351c

Merge remote-tracking branch 'origin/main' into issue620

8547a4c

update code

44b7ccd

dl239 approved these changes Mar 29, 2022

View reviewed changes

update onebox

7a3fdb9

keyu813 mentioned this pull request Mar 29, 2022

PRE_AGG_META table can't create in standalone mode #1523

Closed

dl239 mentioned this pull request Mar 29, 2022

Collect v0.4.4 features #1530

Closed

“keyu813” added 2 commits March 29, 2022 15:17

update stop_all.sh

d28f588

update

727fc12

vagetablechicken approved these changes Mar 30, 2022

View reviewed changes

java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java Outdated Show resolved Hide resolved

“keyu813” added 2 commits March 30, 2022 10:56

update

9d98c8c

update

73e018d

aceforeverd reviewed Mar 30, 2022

View reviewed changes

“keyu813” added 3 commits March 30, 2022 11:54

update

4e5a72d

update code

d3ddf94

update

89ea7ea

aceforeverd approved these changes Mar 30, 2022

View reviewed changes

aceforeverd merged commit caf3c3a into 4paradigm:main Mar 30, 2022

dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 31, 2022

resolve 4paradigm#1485 conflict

a2a135d

lumianph mentioned this pull request Apr 28, 2022

OpenMLDB v0.4 Roadmap #1520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add standalone mode in java sdk #1485

feat: add standalone mode in java sdk #1485

keyu813 commented Mar 21, 2022 •

edited

Loading

github-actions bot commented Mar 21, 2022 •

edited

Loading

github-actions bot commented Mar 21, 2022 •

edited

Loading

dl239 commented Mar 21, 2022

keyu813 commented Mar 21, 2022

codecov bot commented Mar 21, 2022 •

edited

Loading

aceforeverd Mar 30, 2022

vagetablechicken Mar 30, 2022 •

edited

Loading

aceforeverd Mar 30, 2022

keyu813 Mar 30, 2022

vagetablechicken Mar 30, 2022 •

edited

Loading

aceforeverd Mar 30, 2022

keyu813 Mar 30, 2022

feat: add standalone mode in java sdk #1485

feat: add standalone mode in java sdk #1485

Conversation

keyu813 commented Mar 21, 2022 • edited Loading

github-actions bot commented Mar 21, 2022 • edited Loading

SDK Test Report

github-actions bot commented Mar 21, 2022 • edited Loading

Linux Test Report

dl239 commented Mar 21, 2022

keyu813 commented Mar 21, 2022

codecov bot commented Mar 21, 2022 • edited Loading

Codecov Report

aceforeverd Mar 30, 2022

Choose a reason for hiding this comment

vagetablechicken Mar 30, 2022 • edited Loading

Choose a reason for hiding this comment

aceforeverd Mar 30, 2022

Choose a reason for hiding this comment

keyu813 Mar 30, 2022

Choose a reason for hiding this comment

vagetablechicken Mar 30, 2022 • edited Loading

Choose a reason for hiding this comment

aceforeverd Mar 30, 2022

Choose a reason for hiding this comment

keyu813 Mar 30, 2022

Choose a reason for hiding this comment

keyu813 commented Mar 21, 2022 •

edited

Loading

github-actions bot commented Mar 21, 2022 •

edited

Loading

github-actions bot commented Mar 21, 2022 •

edited

Loading

codecov bot commented Mar 21, 2022 •

edited

Loading

vagetablechicken Mar 30, 2022 •

edited

Loading

vagetablechicken Mar 30, 2022 •

edited

Loading