Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support date udf with new date format for UnsafeRowOpt #1469

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Mar 17, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Mar 17, 2022
@tobegit3hub tobegit3hub self-assigned this Mar 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

Linux Test Report

       51 files       177 suites   44m 17s ⏱️
  8 493 tests   8 493 ✔️ 0 💤 0
12 594 runs  12 594 ✔️ 0 💤 0

Results for commit 448e1df.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

SDK Test Report

  70 files    70 suites   4m 55s ⏱️
157 tests 154 ✔️ 3 💤 0
196 runs  193 ✔️ 3 💤 0

Results for commit 448e1df.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1469 (448e1df) into main (e1902c9) will increase coverage by 0.01%.
The diff coverage is 60.20%.

@@             Coverage Diff              @@
##               main    #1469      +/-   ##
============================================
+ Coverage     66.04%   66.05%   +0.01%     
- Complexity      277      281       +4     
============================================
  Files           571      571              
  Lines        107801   107858      +57     
  Branches        904      907       +3     
============================================
+ Hits          71196    71249      +53     
- Misses        36413    36417       +4     
  Partials        192      192              
Impacted Files Coverage Δ
...m/_4paradigm/openmldb/common/codec/RowBuilder.java 44.86% <0.00%> (+0.83%) ⬆️
.../com/_4paradigm/openmldb/common/codec/RowView.java 47.59% <0.00%> (+0.99%) ⬆️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 64.02% <40.98%> (-2.02%) ⬇️
...paradigm/openmldb/batch/nodes/RowProjectPlan.scala 82.69% <100.00%> (+2.69%) ⬆️
...om/_4paradigm/openmldb/common/codec/CodecUtil.java 58.73% <100.00%> (+15.25%) ⬆️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/tablet/tablet_impl.cc 38.78% <0.00%> (+0.08%) ⬆️
src/zk/zk_client.cc 83.55% <0.00%> (+0.26%) ⬆️
src/replica/log_replicator.cc 79.47% <0.00%> (+0.65%) ⬆️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 65.44% <0.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1902c9...448e1df. Read the comment docs.

@vagetablechicken vagetablechicken enabled auto-merge (squash) March 17, 2022 10:43
@vagetablechicken vagetablechicken merged commit 28ac719 into 4paradigm:main Mar 17, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get incorrect result for date columns with UnsafeRowOpt
3 participants