Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(1447): rename spName to deploymentName in SqlExecutor #1467

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

aimanfatima
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)
    Rename spName to deploymentName in SqlExecutor #1447

  • What is the new behavior (if this is a feature change)?
    n/a

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@aimanfatima aimanfatima changed the title Rename spName to deploymentName in SqlExecutor refactor(1447): rename spName to deploymentName in SqlExecutor Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1467 (84274e9) into main (e1902c9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1467      +/-   ##
============================================
- Coverage     66.04%   66.04%   -0.01%     
  Complexity      277      277              
============================================
  Files           571      571              
  Lines        107801   107801              
  Branches        904      904              
============================================
- Hits          71196    71193       -3     
- Misses        36413    36416       +3     
  Partials        192      192              
Impacted Files Coverage Δ
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java 50.50% <0.00%> (ø)
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/sdk_catalog.cc 73.40% <0.00%> (-1.07%) ⬇️
src/sdk/sql_cluster_router.cc 43.65% <0.00%> (-0.33%) ⬇️
src/nameserver/name_server_impl.cc 37.61% <0.00%> (+0.01%) ⬆️
src/tablet/tablet_impl.cc 38.78% <0.00%> (+0.08%) ⬆️
src/replica/log_replicator.cc 79.47% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1902c9...84274e9. Read the comment docs.

@dl239 dl239 linked an issue Mar 17, 2022 that may be closed by this pull request
@vagetablechicken vagetablechicken merged commit 26f7785 into 4paradigm:main Mar 17, 2022
@dl239 dl239 mentioned this pull request Mar 29, 2022
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 30, 2022
@lumianph lumianph mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename spName to deploymentName in SqlExecutor
3 participants