-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use sql for show jobs and show job command #1453
Merged
vagetablechicken
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/use_sql_for_show_jobs_command
Mar 17, 2022
Merged
feat: use sql for show jobs and show job command #1453
vagetablechicken
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/use_sql_for_show_jobs_command
Mar 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
Mar 15, 2022
- Resolve Fail to get correct result for SHOW JOBS command #1446 .
dl239
reviewed
Mar 15, 2022
dl239
reviewed
Mar 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
=========================================
Coverage 66.07% 66.08%
Complexity 277 277
=========================================
Files 571 571
Lines 107802 107798 -4
Branches 913 913
=========================================
+ Hits 71234 71238 +4
+ Misses 36376 36368 -8
Partials 192 192
Continue to review full report at Codecov.
|
tobegit3hub
commented
Mar 17, 2022
Do not use sql concat. |
vagetablechicken
approved these changes
Mar 17, 2022
dl239
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.