Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sql for show jobs and show job command #1453

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Mar 15, 2022
@tobegit3hub tobegit3hub requested a review from dl239 March 15, 2022 10:08
@tobegit3hub tobegit3hub self-assigned this Mar 15, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Mar 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

Linux Test Report

       51 files       177 suites   41m 8s ⏱️
  8 123 tests   8 123 ✔️ 0 💤 0
12 039 runs  12 039 ✔️ 0 💤 0

Results for commit 80c00ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

SDK Test Report

  67 files    67 suites   4m 32s ⏱️
147 tests 144 ✔️ 3 💤 0
180 runs  177 ✔️ 3 💤 0

Results for commit 80c00ad.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1453 (80c00ad) into main (24db81b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #1453   +/-   ##
=========================================
  Coverage     66.07%   66.08%           
  Complexity      277      277           
=========================================
  Files           571      571           
  Lines        107802   107798    -4     
  Branches        913      913           
=========================================
+ Hits          71234    71238    +4     
+ Misses        36376    36368    -8     
  Partials        192      192           
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 44.05% <0.00%> (+0.08%) ⬆️
src/nameserver/name_server_impl.cc 37.61% <0.00%> (ø)
src/tablet/tablet_impl.cc 38.81% <0.00%> (+0.02%) ⬆️
hybridse/src/planv2/ast_node_converter.cc 94.32% <0.00%> (+0.15%) ⬆️
src/zk/zk_client.cc 83.81% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24db81b...80c00ad. Read the comment docs.

@tobegit3hub
Copy link
Collaborator Author

Do not use sql concat.

@vagetablechicken vagetablechicken enabled auto-merge (squash) March 17, 2022 10:46
@vagetablechicken vagetablechicken merged commit e60c247 into 4paradigm:main Mar 17, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to get correct result for SHOW JOBS command
3 participants