Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix show deployment #1415

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Mar 10, 2022

Error msg is empty if execute show deployment failed

@dl239 dl239 added the bug Something isn't working label Mar 10, 2022
@dl239 dl239 linked an issue Mar 10, 2022 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1415 (6aefac5) into main (c290390) will decrease coverage by 1.96%.
The diff coverage is 100.00%.

❗ Current head 6aefac5 differs from pull request most recent head 6ffb857. Consider uploading reports for the commit 6ffb857 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1415      +/-   ##
============================================
- Coverage     67.47%   65.50%   -1.97%     
- Complexity        0      236     +236     
============================================
  Files           512      571      +59     
  Lines        102647   106972    +4325     
  Branches        287      859     +572     
============================================
+ Hits          69259    70071     +812     
- Misses        33388    36749    +3361     
- Partials          0      152     +152     
Impacted Files Coverage Δ
src/cmd/sql_cmd_test.cc 100.00% <100.00%> (ø)
src/sdk/sql_cluster_router.cc 38.63% <100.00%> (+0.51%) ⬆️
...om/_4paradigm/openmldb/batch/nodes/LimitPlan.scala 50.00% <0.00%> (-50.00%) ⬇️
...m/_4paradigm/openmldb/batch/nodes/RenamePlan.scala 50.00% <0.00%> (-50.00%) ⬇️
...m/_4paradigm/openmldb/batch/nodes/SortByPlan.scala 60.00% <0.00%> (-40.00%) ⬇️
...penmldb/batch/utils/AutoDestructibleIterator.scala 63.63% <0.00%> (-36.37%) ⬇️
...digm/openmldb/batch/window/WindowAggPlanUtil.scala 61.81% <0.00%> (-31.34%) ⬇️
...com/_4paradigm/openmldb/batch/utils/CaseUtil.scala 78.57% <0.00%> (-21.43%) ⬇️
...radigm/openmldb/batch/nodes/DataProviderPlan.scala 62.50% <0.00%> (-20.84%) ⬇️
...paradigm/openmldb/batch/udf/PercentileApprox.scala 36.36% <0.00%> (-20.78%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c290390...6ffb857. Read the comment docs.

@github-actions
Copy link
Contributor

Linux Test Report

     112 files       238 suites   43m 53s ⏱️
  8 621 tests   8 618 ✔️ 3 💤 0
12 753 runs  12 750 ✔️ 3 💤 0

Results for commit 6ffb857.

@vagetablechicken vagetablechicken enabled auto-merge (squash) March 10, 2022 10:47
@vagetablechicken vagetablechicken merged commit 0279b70 into 4paradigm:main Mar 10, 2022
@dl239 dl239 mentioned this pull request Mar 29, 2022
dl239 added a commit to dl239/OpenMLDB that referenced this pull request Mar 30, 2022
* fix: fix show deployment

* test: add init
@lumianph lumianph mentioned this pull request Apr 28, 2022
@dl239 dl239 deleted the fix/show_deployment branch November 16, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error msg is empty if execute show deployment failed
3 participants