fix: print import rows count after finished #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 4paradigm#1327 attempt fix. Made integer variable within while loop that reads lines. After loop finishes, uses System.out.println to output the number.
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
============================================
- Coverage 65.48% 65.48% -0.01%
Complexity 236 236
============================================
Files 571 571
Lines 106952 106965 +13
Branches 859 859
============================================
+ Hits 70040 70047 +7
- Misses 36760 36766 +6
Partials 152 152
Continue to review full report at Codecov.
|
java/openmldb-import/src/main/java/com/_4paradigm/openmldb/importer/Importer.java
Outdated
Show resolved
Hide resolved
java/openmldb-import/src/main/java/com/_4paradigm/openmldb/importer/Importer.java
Outdated
Show resolved
Hide resolved
vagetablechicken
changed the title
Addressed comments left about comment placement and print statement.
aceforeverd
reviewed
Mar 9, 2022
java/openmldb-import/src/main/java/com/_4paradigm/openmldb/importer/Importer.java
Outdated
Show resolved
Hide resolved
removed trailing whitespace
lumianph
approved these changes
Mar 10, 2022
vagetablechicken
approved these changes
Mar 10, 2022
dl239
pushed a commit
to dl239/OpenMLDB
that referenced
this pull request
Mar 11, 2022
Made integer variable within while loop that reads lines. After loop finishes, uses System.out.println to output the number.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fix that allows importer to know number of rows read. Resolve #1327
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: