Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove set from src/base #1366

Merged
merged 1 commit into from
Mar 3, 2022
Merged

refactor: remove set from src/base #1366

merged 1 commit into from
Mar 3, 2022

Conversation

Cupid0320
Copy link
Contributor

@Cupid0320 Cupid0320 commented Mar 3, 2022 •
edited by dl239
Loading

close #1289

@Cupid0320 Cupid0320 closed this Mar 3, 2022
@Cupid0320 Cupid0320 deleted the cupid branch March 3, 2022 07:08
@Cupid0320 Cupid0320 restored the cupid branch March 3, 2022 07:14
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Linux Test Report

     110 files       236 suites   40m 30s ⏱️
  8 613 tests   8 610 ✔️ 3 💤 0 ❌
12 745 runs  12 742 ✔️ 3 💤 0 ❌

Results for commit 499f17d.

♻️ This comment has been updated with latest results.

@Cupid0320 Cupid0320 changed the title Remove set from src/base fix: remove set from src/base Mar 3, 2022
@Cupid0320 Cupid0320 reopened this Mar 3, 2022
@Cupid0320 Cupid0320 closed this Mar 3, 2022
@dl239
Copy link
Collaborator

dl239 commented Mar 3, 2022 •
edited
Loading

hi @Cupid0320 , thank you for posting the pr. this pr is closed by mistake? I reopen it now.

@dl239 dl239 reopened this Mar 3, 2022
@dl239 dl239 changed the title fix: remove set from src/base refactor: remove set from src/base Mar 3, 2022
@dl239 dl239 linked an issue Mar 3, 2022 that may be closed by this pull request
Remove set from src/base dir #1289
Closed
@dl239 dl239 merged commit 158bff3 into 4paradigm:main Mar 3, 2022
@Cupid0320 Cupid0320 deleted the cupid branch March 3, 2022 13:34
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 11, 2022
@Cupid0320 @dl239
delete set.h (4paradigm#1366)
35170de
@lumianph lumianph mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@dl239 dl239 dl239 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove set from src/base dir
3 participants
@Cupid0320 @dl239 @vagetablechicken